Repository navigation
Package managers: wait for first store approval instead of failing every release - #34
Merged
Merged
Conversation
…ery release Every release since v0.1.33 failed the Package managers workflow: winget-releaser can only update a package that already exists in winget-pkgs (first PR #442614 is waiting for a moderator), and Chocolatey returns 403 while the first version (0.1.32) is still in moderation. - scripts/package-manager-preflight.ps1 reads public store state (winget-pkgs manifests and open PRs; Chocolatey exact-version and latest-approved records) and returns ready / up-to-date / superseded / submitted-pending / waiting-first-approval. Pending states warn and succeed; store API errors and actual submission errors still fail. -SelfCheck runs the decision table. - Workflow: submit only when preflight says ready; render/pack failure blocks both stores; one store's failure does not skip the other; weekly catch-up run and optional dispatch tag (blank = latest release); inputs passed through env; native exit codes checked; WINGET_TOKEN authenticated outside pull requests. - README and packaging README describe the current status.
Owner
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Package managers workflow has failed on every release since v0.1.33 (runs for v0.1.33–v0.1.39, e.g. 37737330918). Rendering and packing worked each time; both submit steps failed:
Package 'Nativune.Nativune' does not exist in the winget-pkgs repository. winget-releaser only updates existing packages, and the first submission (New package: Nativune.Nativune version 0.1.32 microsoft/winget-pkgs#442614, 0.1.32) is still waiting for a moderator.403 (Forbidden)on push. 0.1.32 is still in moderation (verification pending), and Chocolatey rejects new versions of a package with no approved version.The v0.1.27–v0.1.32 release runs were green only because the store secrets were not configured yet, so the submit steps were skipped.
Change
scripts/package-manager-preflight.ps1checks public store state before submitting: winget-pkgs manifest directory and open PRs from our fork; Chocolatey exact-version record and the latest approved version. States:ready,up-to-date,superseded,submitted-pending,waiting-first-approval. Pending states emit a warning and a step summary but don't fail the job. Any store API error, unexpected status, or missing initial submission fails.-SelfCheckruns the decision table (22 cases) at the start of every run.ready. A render or pack failure blocks both stores; one store's failure doesn't skip the other. Actual submission errors (including a Chocolatey 403) still fail. Added a weekly catch-up run and an optional dispatch tag (blank = latest stable release), so the latest release is submitted once the first approvals land, without resubmitting versions that are already approved or pending. Inputs go throughenv, native exit codes are checked, andWINGET_TOKENis authenticated outside pull requests. Chocolatey key validity can only be confirmed by a real push.Verification
-SelfCheck: 22/22 PASS.waiting-first-approval(#442614), Chocolatey →waiting-first-approval(0.1.32 Submitted); both exit 0.jqpackage on both stores returnedup-to-date,supersededandreadyfor current, older and unreleased versions.