Skip to content

chore: update package versions#59

Merged
HandyS11 merged 2 commits intodevelopfrom
chore/update-packages
Mar 12, 2026
Merged

chore: update package versions#59
HandyS11 merged 2 commits intodevelopfrom
chore/update-packages

Conversation

@HandyS11
Copy link
Owner

This pull request includes several improvements and updates, primarily focused on dependency updates, a refactor of the Tarjan strongly connected components algorithm, and minor test code cleanup. The most significant changes are outlined below.

Dependency Updates

  • Updated multiple NuGet package versions in Directory.Packages.props, including Microsoft.Build, Microsoft.CodeAnalysis.CSharp, Microsoft.EntityFrameworkCore, and related libraries to their latest patch or minor versions.
  • Updated the .NET SDK version in global.json from 10.0.103 to 10.0.200.

Tarjan Algorithm Refactor

  • Refactored the iterative implementation of Tarjan's strongly connected components algorithm in TarjanSccAlgorithm.cs:
    • Extracted neighbor-pushing logic into a new helper method TryPushNeighbor, improving readability and maintainability. [1] [2] [3]
    • Moved the SCC collection logic into a dedicated CollectSccComponent method, further clarifying responsibilities within the algorithm.
    • Cleaned up redundant or now-unnecessary code related to stack frame and lowlink updates.

Test Code Cleanup

  • Simplified array initialization in a unit test by replacing Array.Empty<string>() with the shorthand [] in NullOutputConsoleTests.cs.

Copilot AI review requested due to automatic review settings March 12, 2026 11:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates repository dependencies/.NET SDK, and refactors the iterative Tarjan SCC implementation to improve readability by extracting helper methods, with a small unit test cleanup.

Changes:

  • Bumped .NET SDK in global.json and updated multiple centrally-managed NuGet package versions.
  • Refactored TarjanSccAlgorithm by extracting neighbor traversal and SCC collection into dedicated helpers.
  • Simplified an empty array argument in NullOutputConsoleTests.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
tests/ProjGraph.Tests.Unit.Core/NullOutputConsoleTests.cs Minor test cleanup using collection expression for empty choices.
src/ProjGraph.Lib.Core/Domain/Algorithms/TarjanSccAlgorithm.cs Refactor of iterative Tarjan SCC logic into helper methods for readability/maintainability.
global.json Updates pinned .NET SDK version to 10.0.200.
Directory.Packages.props Central package version bumps for build tooling, Roslyn, EF Core, and Microsoft.Extensions.* packages.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@HandyS11 HandyS11 merged commit 7f5d3c3 into develop Mar 12, 2026
3 checks passed
@HandyS11 HandyS11 deleted the chore/update-packages branch March 12, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants