Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates repository dependencies/.NET SDK, and refactors the iterative Tarjan SCC implementation to improve readability by extracting helper methods, with a small unit test cleanup.
Changes:
- Bumped .NET SDK in
global.jsonand updated multiple centrally-managed NuGet package versions. - Refactored
TarjanSccAlgorithmby extracting neighbor traversal and SCC collection into dedicated helpers. - Simplified an empty array argument in
NullOutputConsoleTests.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/ProjGraph.Tests.Unit.Core/NullOutputConsoleTests.cs | Minor test cleanup using collection expression for empty choices. |
| src/ProjGraph.Lib.Core/Domain/Algorithms/TarjanSccAlgorithm.cs | Refactor of iterative Tarjan SCC logic into helper methods for readability/maintainability. |
| global.json | Updates pinned .NET SDK version to 10.0.200. |
| Directory.Packages.props | Central package version bumps for build tooling, Roslyn, EF Core, and Microsoft.Extensions.* packages. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several improvements and updates, primarily focused on dependency updates, a refactor of the Tarjan strongly connected components algorithm, and minor test code cleanup. The most significant changes are outlined below.
Dependency Updates
Directory.Packages.props, includingMicrosoft.Build,Microsoft.CodeAnalysis.CSharp,Microsoft.EntityFrameworkCore, and related libraries to their latest patch or minor versions.global.jsonfrom10.0.103to10.0.200.Tarjan Algorithm Refactor
TarjanSccAlgorithm.cs:TryPushNeighbor, improving readability and maintainability. [1] [2] [3]CollectSccComponentmethod, further clarifying responsibilities within the algorithm.Test Code Cleanup
Array.Empty<string>()with the shorthand[]inNullOutputConsoleTests.cs.