Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into this when pasting a command longer than the terminal height. Bash received the whole command, but after pressing Enter I couldn't scroll back to its beginning. With 210 lines in an 80x24 terminal, the first 187 lines were missing.
The final redraw was using the same clipped row range as the editor. This writes the hidden prefix of the final content into scrollback, then lets the normal draw render the remaining rows. It uses the final prompt and current command text, including any edits.
The editing viewport and Ctrl+C/EOF behavior stay the same. This uses the existing inline backend APIs; the Ratatui fork and dependencies are unchanged.
Testing:
only-prompt-posintegration.cargo fmt --all -- --checkand clippy with-D warningspass.This doesn't expose the entire active edit buffer through native scrollback. Single-row viewport edge cases and old rows retained during resizing with shell integration disabled are outside this fix. Other GUI terminals haven't been checked.