docs: close the v1.0 parity gaps (#1081, #1083, #1084, #985) - #1364
Merged
Conversation
…ourney Closes the remaining gaps on #1081, #1084, #1083, and #985 left over from the earlier ba72db2 sweep: - #1081: baremetal-ubuntu.mdx / proxmox-lxc.mdx now mention amdttm.pages_limit as the out-of-tree-TTM-module equivalent of ttm.pages_limit, with the modinfo check to tell which applies; memory-map.jsx's stale amdgpu.gttsize code comment now says ttm.pages_limit. - #1083: first-model.mdx documents the pull destination ([models].store, falling back to the deprecated pull_root, set via hal0 setup --storage-dir or hal0 model store). - #1084: first-model.mdx's "Starting from zero" section now covers the OpenWebUI empty model selector and corrects the hal0 status/hal0 slot list claim — the installer scaffolds slot structure (no --no-slots in install.sh), so slots show up with no model assigned rather than an empty list. Verified the installer "Next steps" block and the dashboard FirstRunBanner copy already point at hal0 setup / hal0 model pull correctly; no in-product changes were needed. - #985: retired the 'cognee' memory-engine enum value (schema.py) now that v1.0.0 is the scheduled HAL0-SUNSET removal point — the validator rejects it instead of silently resolving it to hindsight; updated the matching test and the config-schema.mdx / configure.mdx docs. Stripped the last two dangling non-ADR-0023 comment citations (ADR-0004 in agents/manager.py, ADR-0012 in provider_hal0/profile.py) preserving their inline rationale. Removed enable-memory.mdx's "Migrate a legacy store" section, which documented a hal0 memory migrate --cognee-dir flag that no longer exists in the CLI (migrate now only does Honcho<->Hindsight); pointed readers at the real command in honcho-memory.mdx instead. Verified: ruff check/format clean; tests/config + tests/memory + tests/agents/test_manager.py all pass (854 passed, 9 skipped); internal /docs/ links in every changed file resolve to an existing page. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…urce The ADR-citation cleanup edited src/hal0/agents/hermes/plugins/provider_hal0/ profile.py; installer/agents/hermes/plugins/hal0-provider/profile.py is a byte-identical seed copy pinned by a drift test. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
thinmintdev
enabled auto-merge (squash)
July 27, 2026 14:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1081. Closes #1083. Closes #985. Partially addresses #1084.
A prior partial sweep (
ba72db29, #1280) had already done most of the substance; this closes the remainder.amdttm.pages_limit(out-of-tree TTM) +modinfocheck, fixed a staleamdgpu.gttsizecomment inmemory-map.jsx:124. The issues literal acceptance criterion (emptygrep -rn amdgpu.gttsize) cannot be fully met — the deprecation prose has to name the parameter it deprecates.[models].store, deprecatedpull_rootfallback,/var/lib/hal0/models), verified againstconfig/schema.py:2631-2654,cli/setup_command.py:182,install/orchestrate.py:439,config/paths.py:138-140.install.sh:2377-2380,FirstRunBanneratprimitives.jsx:598-611); no code needed. Butfirst-model.mdxclaimed a fresh box shows "no slots configured" — false. The installers default path scaffolds slot structure, sohal0 slot listshows real slots with an empty Model column; that string only appears after--no-slots. Corrected.ADR-00NNhits, 51 areADR-0023(the surviving ADR) or runtime string literals consumed by callers. Fixed the 2 genuine dangling citations.Retired the
cogneememory-engine enum inconfig/schema.py— the validator now rejects it instead of silently resolving to hindsight. CarriesHAL0-SUNSET: v1.0.0and this is that release. Needs a CHANGELOG Breaking entry.Verification
tests/config tests/memory tests/agents/test_manager.py→ 854 passed, 9 skippedNotes
docs/**here is a mirror of hal0-web; the.mdxhalf is ported separately in hal0-web or the next sync clobbers it. The Python/UI changes correctly live here.migrate_cognee_to_hindsight_dryruninmemory/migrate.pyis orphaned dead code — unwired to any CLI command, sincehal0 memory migrateis Hindsight↔Honcho only. Needs a maintainer decision: wire or delete.enable-memory.mdxdocumented a--cognee-dirflag that no longer exists; section deleted.🤖 Generated with Claude Code