Rebuild AudioMixerBySingleTrack outputFormat on settings sampleRate/c…#1907
Closed
dawilster wants to merge 1 commit into
Closed
Rebuild AudioMixerBySingleTrack outputFormat on settings sampleRate/c…#1907dawilster wants to merge 1 commit into
dawilster wants to merge 1 commit into
Conversation
…hannels change AudioMixerBySingleTrack.settings.didSet only applied per-track sub-settings. If an input buffer arrived before the app assigned its intended settings, the mixer's outputFormat was locked to the raw input format for the life of the mixer — subsequent sampleRate/channels changes were silently ignored. This manifested in production as silent live streams when using external mics (48 kHz / 2 ch native) that published AAC at the mic's raw format instead of the configured 44.1 kHz / 1 ch. The built-in iPhone mic masked the bug because its native format matched the app's target. The fix uses the existing AudioMixerSettings.invalidateOutputFormat(_:) helper — the same pattern AudioCodec.settings.didSet already uses with its invalidateConverter check — to recompute outputFormat from the current inSourceFormat when sampleRate or channels change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix for #1906