Conversation
This was referenced Apr 22, 2025
Contributor
|
This is awesome :D Really cool. So after reviews, you want to force merge this despite failing Validate links check? And fix them after in #23? |
Contributor
Author
Yay!
Yeah I think that's best. Once it's in place and passing, then it can be set as a required check. |
adamblanchard
approved these changes
Apr 22, 2025
Contributor
Author
It wouldn't need a force-merge, I think? AFAICT, neither of the checks (linter, and link checker) have been marked as required checks yet. |
saloumeh-67
approved these changes
Apr 25, 2025
rvedotrc
force-pushed
the
link-checker
branch
2 times, most recently
from
92d61a3 to
a9f945e
Compare
This was referenced Apr 27, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checks that local markdown links to other markdown docs, or to images, are valid. i.e. the file being linked to actually exists.
See #23 for what the fixes look like.