Test and improve Nextflow pipeline: fix bugs, add stubs, add CI - #15
Draft
bruno-ariano with Copilot wants to merge 6 commits into
Draft
Test and improve Nextflow pipeline: fix bugs, add stubs, add CI#15bruno-ariano with Copilot wants to merge 6 commits into
bruno-ariano with Copilot wants to merge 6 commits into
Conversation
…with tests Co-authored-by: bruno-ariano <26384813+bruno-ariano@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor functions into modules for better organization
Refactor: split monolithic export command into focused modules + add pytest suite
Mar 5, 2026
… 32 tests + README update Co-authored-by: bruno-ariano <26384813+bruno-ariano@users.noreply.github.com>
Copilot
AI
changed the title
Refactor: split monolithic export command into focused modules + add pytest suite
Refactor: split monolithic harmonize_ingest.py and export.py into focused sub-modules
Mar 5, 2026
… docs Co-authored-by: bruno-ariano <26384813+bruno-ariano@users.noreply.github.com>
Copilot
AI
changed the title
Refactor: split monolithic harmonize_ingest.py and export.py into focused sub-modules
Refactor ingestion into sub-modules, add Nextflow tests and CI, fix pipeline bugs
Mar 5, 2026
Copilot
AI
changed the title
Refactor ingestion into sub-modules, add Nextflow tests and CI, fix pipeline bugs
Test and improve Nextflow pipeline: fix bugs, add stubs, add CI
Mar 7, 2026
added 2 commits
April 4, 2026 19:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Nextflow pipeline had broken CLI flags in
modules/regions/main.nf,EXPORT_REGIONSwas imported but never wired into the workflow, and there was no way to validate the pipeline DAG without containers or real data.Bug fixes
modules/regions/main.nf: removed nonexistent--workersflag;--table_regions→--table-regions;--tiledb_lb_typesumstat→--type_sumstat; output pattern was emitting locusbreaker filenames instead of region CSV outputmain.nf: added missingif (params.regions)block insideif (params.export)soEXPORT_REGIONSis actually invokedStub blocks
Added
stub:blocks to all 8 modules (create_tiledb,ingestion,merge_metadata,snp,regions,locusbreaker,traits,recompute_meta), enabling DAG validation without containers:Test config (
conf/test.config)test_recompute_meta: replaced hardcoded cluster paths with${projectDir}/example_data/recompute_meta_test_table.csvtest_export_traits: points to newtrait_list_test.csv(correctTRAITcolumn format)test_export_regions: params aligned with fixed moduleNew example data files
example_data/example_data_table_test.csvexample_data/trait_list_test.csvTRAITcolumn (Tgd:ENSG…) for traits export testsexample_data/recompute_meta_test_table.csvCELL,CHRformat for recompute-metadata testsCI (
.github/workflows/ci.yml)Three jobs on every push/PR: Python
pytest, Nextflow stub tests for all 6 profiles, and a full integration test that runs ingestion with-process.container null.Docs
docs/README.md: full rewrite — parameter tables for every workflow mode, module reference table, stub/integration testing guideREADME.md: added Nextflow testing section💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.