Skip to content

Recover skipped Stable release announcements safely - #129

Merged
bermanto merged 1 commit into
mainfrom
fix/stable-announcement-recovery
Sep 12, 2026
Merged

bermanto merged 1 commit into
mainfrom
fix/stable-announcement-recovery

Conversation

@bermanto

@bermanto bermanto commented Sep 12, 2026

Copy link
Copy Markdown
Member

Recover a skipped Stable release announcement without rerunning promotion. The new manual workflow verifies the public signed archive against the reviewed evidence, GitHub Latest, the fixed candidate, and the deploy branch, then sends the exact release body through the existing Discord sender.

The workflow has read-only repository permissions and uses the existing protected release environment and webhook. It cannot modify release assets or promote a candidate. Operators must check prior delivery before dispatch; ambiguous sends still require inspection to prevent duplicates.

Validation: full pnpm check and pnpm deploy:dry-run passed; 15 focused verifier/notifier tests passed. The read-only verifier also passed against public Stable 1.4.0. Canonical procedure: HQBase/hqbase-site#56.

Summary by CodeRabbit

  • New Features

    • Added a release announcement workflow that can verify a published Stable release and notify Discord with its release details.
    • Added validation to confirm that the published release, deployment, archive, and evidence all match the reviewed release candidate.
  • Tests

    • Added coverage for successful Stable release verification and detection of publication, deployment, archive, and evidence mismatches.

@coderabbitai

coderabbitai Bot commented Sep 12, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 2760880f-b891-404e-87c4-f70dfa1cbedc

📥 Commits

Reviewing files that changed from the base of the PR and between c9ae749 and 19ff207.

📒 Files selected for processing (3)
  • .github/workflows/announce-stable.yml
  • scripts/release/verify-stable.mjs
  • test/unit/scripts/verify-stable.test.mjs

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The changes add stable release verification, unit coverage for verification failures, and a manually triggered GitHub Actions workflow that sends verified release notes to Discord.

Changes

Stable release announcement

Layer / File(s) Summary
Stable release verification and validation
scripts/release/verify-stable.mjs, test/unit/scripts/verify-stable.test.mjs
The script verifies release tags, publication status, manifest data, evidence reports, source commits, and deploy commits. Unit tests cover valid data and mismatch failures.
Manual announcement workflow
.github/workflows/announce-stable.yml
The workflow accepts a release version on main, runs stable verification, reads the release body, and sends it to Discord through the release notification script.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant GitHub_Actions
  participant verify_stable_mjs
  participant GitHub_API
  participant notify_discord_mjs
  participant Discord
  GitHub_Actions->>verify_stable_mjs: verify release version
  verify_stable_mjs->>GitHub_API: fetch release and deploy metadata
  GitHub_API-->>verify_stable_mjs: return metadata
  verify_stable_mjs-->>GitHub_Actions: verification passes
  GitHub_Actions->>notify_discord_mjs: provide release body and webhook secret
  notify_discord_mjs->>Discord: post release announcement
Loading

Merge Risk: ⚪ Minimal · up to 19ff2

The manual announcement path verifies the release before sending and uses the existing protected environment and read-only repository permissions.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: safely recovering skipped Stable release announcements.
Description check ✅ Passed The description explains the workflow purpose, verification controls, operational precautions, and validation results. It does not use the template headings or checkbox format, but it contains the req…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 2
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/stable-announcement-recovery

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@bermanto
bermanto merged commit d954a27 into main Sep 12, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant