Recover skipped Stable release announcements safely - #129
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe changes add stable release verification, unit coverage for verification failures, and a manually triggered GitHub Actions workflow that sends verified release notes to Discord. ChangesStable release announcement
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant GitHub_Actions
participant verify_stable_mjs
participant GitHub_API
participant notify_discord_mjs
participant Discord
GitHub_Actions->>verify_stable_mjs: verify release version
verify_stable_mjs->>GitHub_API: fetch release and deploy metadata
GitHub_API-->>verify_stable_mjs: return metadata
verify_stable_mjs-->>GitHub_Actions: verification passes
GitHub_Actions->>notify_discord_mjs: provide release body and webhook secret
notify_discord_mjs->>Discord: post release announcement
Merge Risk: ⚪ Minimal · up to The manual announcement path verifies the release before sending and uses the existing protected environment and read-only repository permissions. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Recover a skipped Stable release announcement without rerunning promotion. The new manual workflow verifies the public signed archive against the reviewed evidence, GitHub Latest, the fixed candidate, and the deploy branch, then sends the exact release body through the existing Discord sender.
The workflow has read-only repository permissions and uses the existing protected release environment and webhook. It cannot modify release assets or promote a candidate. Operators must check prior delivery before dispatch; ambiguous sends still require inspection to prevent duplicates.
Validation: full pnpm check and pnpm deploy:dry-run passed; 15 focused verifier/notifier tests passed. The read-only verifier also passed against public Stable 1.4.0. Canonical procedure: HQBase/hqbase-site#56.
Summary by CodeRabbit
New Features
Tests