Skip to content

Prevent sending smaller limit value to the datasource for the last page #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yuppyavd wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Prevent sending smaller limit value to the datasource for the last page #147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions src/main/java/gwt/material/design/client/ui/pager/MaterialDataPager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,18 +165,20 @@ public boolean isLastPage() {
protected void doLoad(int offset, int limit) {
this.offset = offset;

// Check whether the pager has excess rows with given limit
if (isLastPage() & isExcess()) {
// Get the difference between total rows and excess rows
limit = totalRows - offset;
}

int finalLimit = limit;
dataSource.load(new LoadConfig<>(offset, limit, table.getView().getSortContext(),
table.getView().getOpenCategories()), new LoadCallback<T>() {
@Override
public void onSuccess(LoadResult<T> loadResult) {
totalRows = loadResult.getTotalLength();

int finalLimit = limit;

// Check whether the pager has excess rows with given limit
if (isLastPage() & isExcess()) {
// Get the difference between total rows and excess rows
finalLimit = totalRows - offset;
}

table.setVisibleRange(offset, finalLimit);
table.loaded(loadResult.getOffset(), loadResult.getData());
updateUi();
Expand Down