feat(settings): add option to use 24hr clock (#112) - #116
Open
MIR-2004 wants to merge 1 commit into
Open
Conversation
- add 12h/24h clock format toggle to display settings - support 24-hour mode in TimePicker component - update activity form schema and date-time utils to parse and validate both formats - format activity tables and task timestamps according to user clock preference - add UserSettingsContext provider and hooks for clock format state - add unit tests for clock format utilities and TimePicker 24h mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #112
This PR adds an option in the Display Settings to toggle between a 12-hour (AM/PM) and 24-hour clock format. The selected setting is reflected across the entire application:
AddActivityFormSchemaandcombineDateAndTimehelper to parse and validate both 12h and 24h time strings.UserSettingsContextfor reactive dashboard-wide updates upon saving settings.Testing
__tests__/TimePicker.spec.tsxand__tests__/clockFormat.spec.ts.npm run build).