Eliminate spurious TAG (TODO) outputs after multi-line HTML comment#913
Open
quidscio wants to merge 1 commit into
Open
Eliminate spurious TAG (TODO) outputs after multi-line HTML comment#913quidscio wants to merge 1 commit into
quidscio wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identified whitespace pattern modification for HTML multi-line comment compatibility
This PR offers an amended regex to eliminate a extra TODO triggered by a multi-line HTML comment.
The PR also includes an updated test/tests.js to verify original vs updated behavior.
Summary
Before view:
Updated view:
Testcase (text in MD file):
Fix to eliminate unwanted TODO
Change the end-of-line
\s*to[ \t]*.\sincludes newlines.When it found
<!--, the\s*pattern matched the newline and whitespace, then foundTODOon the next line, and treated it like a single match.Changing
\s*to[ \t]*restricts the whitespace matching to only spaces and tabs (no newlines).This ensures TODO items must appear on the same line as their comment marker, preventing false matches when an HTML comment opener appears alone on a line above actual TODO text.
The old and updated regex are:
Testing