Fix/audit findings - #511
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #511 +/- ##
==========================================
- Coverage 83.93% 83.70% -0.23%
==========================================
Files 55 55
Lines 8750 8837 +87
Branches 1037 1057 +20
==========================================
+ Hits 7344 7397 +53
- Misses 1385 1419 +34
Partials 21 21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved issues remain in random OD fallback, capacity rounding, signal-phase handling, and partial network persistence.
Get a fresh assessment by requesting another Copilot review.
Review details
- Files reviewed: 21/21 changed files
- Comments generated: 4
- Review effort level: Lite
Comment on lines
437
to
438
| while (nAgents--) { | ||
| std::optional<Id> srcId{std::nullopt}, dstId{std::nullopt}; |
Comment on lines
+1217
to
+1218
| pNode->setCapacity(value > 0. ? static_cast<std::size_t>(value) | ||
| : static_cast<std::size_t>(1)); |
| } | ||
| } | ||
|
|
||
| if (secondaryGreenTime == 0) { |
| bool edgesTableExists = edgesQuery.executeStep(); | ||
| bool nodesTableExists = nodesQuery.executeStep(); | ||
| if (edgesTableExists && nodesTableExists) { | ||
| if (edgesTableExists || nodesTableExists) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.