refactor[cartesian]: fix some type errors in frontend#2564
Merged
romanc merged 3 commits intoGridTools:mainfrom Apr 14, 2026
Merged
refactor[cartesian]: fix some type errors in frontend#2564romanc merged 3 commits intoGridTools:mainfrom
romanc merged 3 commits intoGridTools:mainfrom
Conversation
romanc
changed the title
2 tasks
romanc
force-pushed
the
romanc/mypy-def-ir-to-gtir
branch
from
fdd507d to
a792786
Compare
twicki
approved these changes
Apr 14, 2026
Contributor
twicki
left a comment
twicki
left a comment
There was a problem hiding this comment.
Looks good, thanks for cleaning up! 🧹🧹
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the flat out "ignore all mypy errors" on
defir_to_gtirandnodeswith a more targeted ignore that only filters"call-arg"errors. These are generated by@attribclassclasses, which - apparently - aren't understood bymypy.In a follow-up PR, we can probably replace
@attribclassclasses with@dataclassclasses. Those seem to serve a similar purpose and are natively understood bymypy.Requirements
N/A