feat[cartesian]: All data dimensions field RHS access needs to be fully defined

[FlorianDeconinck]

Description

Data dimensions fields can be partially indexed on the LHS and should always be fully defined RHS. Some code path leads to error on the RHS being caught way down in the backends.

We introduced a single behavior of require full indexation for every data field, either with the double subscript F[0, 0, 0][x, y] or via the global indexer F.A[x.y].

Implementation:

• Add unit tests to test forbidden not full indexation of data dimensions
• Add a DataDimensionsChecker after the UnrollVectorAssignement

Also:

• Protect the visit_subscript of DefinitionIR parsing against unexpected nodes sub-scripted

BEFORE MERGE:

• ADR modifications ?

Requirements

• All fixes and/or new features come with corresponding tests.
• Important design decisions have been documented in the appropriate ADR inside the docs/development/ADRs/ folder.

[romanc]

Looks good to me. Can temporaries have data dimensions? If so, we should pass temp_decls too such that we don't miss checking them.

[FlorianDeconinck]

Looks good to me. Can temporaries have data dimensions? If so, we should pass temp_decls too such that we don't miss checking them.

I'll check them - good catch

[FlorianDeconinck]

cscs-ci run