-
Notifications
You must be signed in to change notification settings - Fork 27
feat: add monorepo parity features #700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dc7b8d1c89
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
commit: |
|
@codex review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 60a1b4f142
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
- Add sendEvent functionality (cherry-picked from feat/device-events) - Add CALLDATA.SOLANA exports for Solana transaction parsing - Add Constants.DERIVATION_PATHS.SOLANA and ETH - Fix retryCount: 0 semantics to properly disable retries - Export SignData and LatticeSignature types
- Fix compact-u16 (shortvec) decoding to use little-endian byte order (first byte holds low 7 bits, subsequent bytes shift left) - Relax base64 validation to accept non-canonical padding variants by checking decoded length instead of round-trip comparison
f3068ba to
9a9f05d
Compare
Summary
This PR adds features from the internal monorepo to maintain parity between codebases.
Changes
feat/device-eventsbranch, adds device event sending capabilitySOLANAandETHderivation path constants to theEXTERNALobjectretryCount: 0properly disables retries (was being ignored due to falsy check)SignDataandLatticeSignaturetypes from the main indexTesting