Add comments and minor refactors to 'Getting Started' codelab#1
Open
GregoryCannon wants to merge 5 commits intomasterfrom
Open
Add comments and minor refactors to 'Getting Started' codelab#1GregoryCannon wants to merge 5 commits intomasterfrom
GregoryCannon wants to merge 5 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sample of changes I would propose to the source of the "Getting Started" codelab.
Summary:
convertToCode(blocklyXml)to clarify that flow during the save processloadWorkspacetake the parameter of the XML to load instead of the button DOM object