Repository navigation
Copy replaceAll() replacements with their children - #156
Open
gravitypdf-bot wants to merge 3 commits into
Open
gravitypdf-bot wants to merge 3 commits into
gravitypdf-bot wants to merge 3 commits into
Conversation
replaceAll() made a shallow clone of the replacement and a shallow import of that, so each replaced node arrived with its attributes but no children. Import the replacement deeply instead. Fixes #135 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #156 +/- ##
============================================
+ Coverage 90.69% 91.23% +0.53%
- Complexity 1424 1441 +17
============================================
Files 25 26 +1
Lines 3170 3182 +12
============================================
+ Hits 2875 2903 +28
+ Misses 295 279 -16 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #135.
replaceAll()copied each replacement with a shallowcloneNode()and then a shallowimportNode(), so it inserted empty copies. It now copies the whole subtree withimportNode($replacement, true).Tests
tests/Issues/Issue135Test.phpchecks that each inserted copy keeps its attributes, text and children, is a separate node, and leaves the source document untouched.Every PR in this set adds its CHANGELOG line at the end of
# Unreleased changes, so each one after the first needs a one-line conflict resolved there.🤖 Generated with Claude Code