Skip to content

Count positional selectors in prevAll(), parents() and nextAll() in walk order - #153

Open
gravitypdf-bot wants to merge 4 commits into
mainfrom
fix/issue-134
Open

gravitypdf-bot wants to merge 4 commits into
mainfrom
fix/issue-134

Conversation

@gravitypdf-bot

Copy link
Copy Markdown
Contributor

Fixes #134. Behaviour change.

jQuery filters a traversal's walk before sorting it, so a positional selector counts from the starting element outward: prevAll(':first') is the nearest previous sibling, d, not the first sibling, a, and parents(':first') is the parent. This PR does the same for prevAll(), parents() and nextAll():

  • A new private walkAll() joins the walks from each starting element, repeats included, and filters them with the new DOMTraverser::filterList().
  • filterList() counts positional pseudo-classes along the list in the order given. It shares one private core with filterNodes().
  • Selectors with no positional pseudo-class take the same path as before.

prevUntil() and parentsUntil() take only a stop selector, which already counts across the document (#118), so they are unchanged.

Tests

  • tests/Issues/Issue134Test.php covers the issue's table, sets of two starting elements, filterList() directly, and non-positional selectors.
  • Issue118Test::testSetMethodsCountPositionsInDocumentOrder is renamed ...InWalkOrder and its expected values updated. It had pinned the old behaviour and noted that jQuery differed.

Notes

  • The expected results for multi-element sets are worked out from jQuery 3.7.1's source, not run against jQuery.
  • Walks are joined in QueryPath's match-set order. add() doesn't sort its set where jQuery's does, so the two can differ after add().
  • siblings() still counts in document order. That could be a follow-up issue.

Every PR in this set adds its CHANGELOG line at the end of # Unreleased changes, so each one after the first needs a one-line conflict resolved there.

🤖 Generated with Claude Code

gravitypdf-bot and others added 4 commits October 26, 2026 17:18
…alk order

jQuery joins the walk from each starting element, repeats included,
filters that list with jQuery.filter(), then removes the repeats and
sorts. QueryPath counted a positional selector in document order, so
prevAll(':first') was the first sibling rather than the nearest.

Add DOMTraverser::filterList(), which counts positional pseudo-classes
along a list in the order given, and filter the joined walks through it
when the selector is positional.

Fixes #134.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Oct 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.29%. Comparing base (6ae6acf) to head (a59a023).
⚠️ Report is 19 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #153      +/-   ##
============================================
+ Coverage     90.69%   91.29%   +0.59%     
- Complexity     1424     1454      +30     
============================================
  Files            25       26       +1     
  Lines          3170     3204      +34     
============================================
+ Hits           2875     2925      +50     
+ Misses          295      279      -16     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Positional selectors in prevAll(), parents() and the *Until() methods count in document order, not jQuery's walk order

1 participant