Repository navigation
Count positional selectors in prevAll(), parents() and nextAll() in walk order - #153
Open
gravitypdf-bot wants to merge 4 commits into
Open
gravitypdf-bot wants to merge 4 commits into
gravitypdf-bot wants to merge 4 commits into
Conversation
…alk order
jQuery joins the walk from each starting element, repeats included,
filters that list with jQuery.filter(), then removes the repeats and
sorts. QueryPath counted a positional selector in document order, so
prevAll(':first') was the first sibling rather than the nearest.
Add DOMTraverser::filterList(), which counts positional pseudo-classes
along a list in the order given, and filter the joined walks through it
when the selector is positional.
Fixes #134.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #153 +/- ##
============================================
+ Coverage 90.69% 91.29% +0.59%
- Complexity 1424 1454 +30
============================================
Files 25 26 +1
Lines 3170 3204 +34
============================================
+ Hits 2875 2925 +50
+ Misses 295 279 -16 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #134. Behaviour change.
jQuery filters a traversal's walk before sorting it, so a positional selector counts from the starting element outward:
prevAll(':first')is the nearest previous sibling,d, not the first sibling,a, andparents(':first')is the parent. This PR does the same forprevAll(),parents()andnextAll():walkAll()joins the walks from each starting element, repeats included, and filters them with the newDOMTraverser::filterList().filterList()counts positional pseudo-classes along the list in the order given. It shares one private core withfilterNodes().prevUntil()andparentsUntil()take only a stop selector, which already counts across the document (#118), so they are unchanged.Tests
tests/Issues/Issue134Test.phpcovers the issue's table, sets of two starting elements,filterList()directly, and non-positional selectors.Issue118Test::testSetMethodsCountPositionsInDocumentOrderis renamed...InWalkOrderand its expected values updated. It had pinned the old behaviour and noted that jQuery differed.Notes
add()doesn't sort its set where jQuery's does, so the two can differ afteradd().siblings()still counts in document order. That could be a follow-up issue.Every PR in this set adds its CHANGELOG line at the end of
# Unreleased changes, so each one after the first needs a one-line conflict resolved there.🤖 Generated with Claude Code