Allow GPDF_API_URL to be overridden via wp-config.php#1666
Merged
Conversation
Guard the GPDF_API_URL define so a site can point licensing/update requests at a staging endpoint (e.g. the upcoming Cloudflare Worker proxy) from wp-config.php without editing plugin code. Also document why the bulk get_version params must stay numerically indexed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wraps the
GPDF_API_URLdefine in anif ( ! defined() )guard so a site can override the licensing/update endpoint fromwp-config.php. This lets a staging site point at the upcoming Cloudflare Worker licensing proxy without editing plugin code. Also adds a comment documenting why the bulkget_versionparams must stay numerically indexed (the API keys its response array by the same keys it receives, so numeric indices keep the response a JSON array that the response handlers decode viais_array()).Try it
Add to
wp-config.php:Licensing and update checks now hit that endpoint; with no override they continue to use
https://api.gravitypdf.com.Test plan
https://api.gravitypdf.comas beforewp-config.php, requests go to the override endpointMore info
Part of repointing the licensing/update API at a Cloudflare Worker proxy. The proxy-side changes (status passthrough, content-type handling, rate-limit bypass, tests) live in the
gravitypdf-update-serverrepo. The guard is the standard WordPress constant-override idiom and is a no-op when the constant isn't pre-defined.🤖 Generated with Claude Code