Conversation
…(1.8.1)
A page built inside-out via insert_blocks + edit_block_tree.insert-child
rendered correctly in the editor but serialised with children as top-level
siblings on the front end. The wrapper would appear empty and the
"inner" blocks would render outside it.
Root cause: when a container is created with insert_blocks and
innerHTML="<div class=\"wp-block-columns\"></div>" and no children,
parse_blocks reads innerContent back as a single unsplit string
['<div class=\"wp-block-columns\"></div>']. The original insert-child
splice scanned backward for a closing-tag string and inserted the new
child's null placeholder at that index — but with only one string the
null landed BEFORE it, producing [null, '<div></div>']. serialize_blocks
then emitted [child]<div></div>, with the child OUTSIDE the wrapper.
Fix normalises single-string wrappers into [opening, closing] before
the splice, so the new null always falls between them and children
interleave correctly. Pure local change to Block_Mutator; no API or
contract shifts.
- Two new regression tests in BlockMutatorTest:
* test_insert_child_nests_inside_self_closing_wrapper — single
wrapper case (columns + one column).
* test_insert_child_nests_through_multiple_self_closing_wrappers
— multi-level case (columns + column + heading, mirroring the
original BLOCK-20 repro).
- readme.txt changelog + upgrade notice updated.
- Version bumped to 1.8.1 in both plugin header and GK_BLOCK_API_VERSION.
Release 1.8.1 — BLOCK-20 insert-child nesting fix
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
WalkthroughThis PR bumps the plugin to version 1.8.1 and fixes a serialization bug where nested container blocks created via ChangesNested Container Insertion Fix and Version 1.8.1 Release
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes the BLOCK-20 fix from `develop` to `main` for release.
Summary
What's included
Root cause
Containers created with `insert_blocks(innerHTML="<div…>", innerBlocks=[])` parse back with `innerContent` stored as a single unsplit string. The original `insert-child` splice landed the null placeholder BEFORE that string, so `serialize_blocks` emitted children OUTSIDE the wrapper. The fix normalises single-string wrappers into `[opening, closing]` before the splice.
Test plan
Release artifacts
Summary by CodeRabbit
Release Notes - Version 1.8.1
Bug Fixes
Chores