Address HTML markup issues reported by Herb - #946
Open
marcoroth wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While I was working on RubyEvents and updating lightning talks I came across StockAid and saw it's written in HTML+ERB. Naturally what I do is try to run my new Herb toolchain I'm working on it and see what it finds.
This pull request addresses the issues it reported: two missing or mistyped closing tags, a
<ul>nested inside a<p>, and 15 ERB output tags in attribute position (<%= "selected" if … %>) rewritten to control flow with static attributes.If it'd be useful, I'm happy to follow up with a small CI step so these don't creep back in, but no worries if you'd rather not.