fix(security): Revoke account sessions and bound build resources - #206
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Disabling an account or recovering its password previously left existing sessions usable, while build logs and container exports could grow Node memory without a bound.
Validation
just quality: passed; Rust reported 671 passing tests and Console 239 passing tests across 63 files. The default Rust suite excludes 18 explicitly ignored tests; 15 of those were run separately below.cargo test -p grass-control-api infra::database::migrate::tests:: -- --ignored: 13 passed on disposable PostgreSQL, including authentication-version column shape, constraints, migration tracking, and account/password revocation using both Moka and Redis. Covered delayed stale cache writes and login with each new password.cargo test -p grass-control-api redis_rejects_revoked_accounts_at_read_and_write_boundaries -- --ignored: passed against disposable Redis.cargo test -p grass-node docker_build_exports_logs_and_failure_cleanup -- --ignored: passed against Docker, covering static/SSR directory exports, excessive logs, timeout, symlink rejection, and container cleanup.cargo test -p grass-cache: 12 passed with the real Redis tests enabled.Tracking
Closes #203
Closes #204
Closes #205
Closes #202 (parent issue)
Known Limitations
users.auth_version. Pre-upgrade sessions lack a valid version and require a fresh login. Password changes intentionally invalidate the initiating session as well.