Skip to content

refactor(core): Remove obsolete code and consolidate shared behavior - #201

Merged
yuanzui-cf merged 6 commits into
mainfrom
refactor/code-cleanup
Sep 12, 2026
Merged

yuanzui-cf merged 6 commits into
mainfrom
refactor/code-cleanup

Conversation

@yuanzui-cf

Copy link
Copy Markdown
Member

Summary

Remove obsolete internal APIs, unused dependencies, stale lint exemptions, and DNS challenge write paths left behind by the HTTP-01 transition. Compile the fake container runtime only for tests and simplify redundant runtime, migration-test, and Console route wrappers.

Share storage configuration parsing and Console field models, including consistent credential trimming. Centralize HTTP database/cache access and domain deletion: both deletion endpoints use the persisted deletion timestamp for quota idempotency, preserve administrator auditing, and attempt route invalidation even when cleanup encounters an infrastructure error.

Reuse Console setting switches, settings navigation, account-menu presentation/logout handling, and safe timestamp formatting. Keep navigation permissions with the calling layout and retain DNS ownership verification and protocol/security abstractions.

Validation

  • just quality passed before every commit: Rust formatting, Clippy, workspace tests/check/build, Console checks/tests/build, and license checks.
  • Storage regressions: 35 Rust tests and 6 Console tests passed.
  • Host binding service regressions: 5 tests passed, covering persisted deletion generations, repeated deletion, restoration, project isolation, DNS failures, and authenticated route invalidation against a local mock Serve Node.
  • Console: 237 tests across 63 files passed, including creation-menu restrictions and successful/failed logout behavior.
  • cargo tree --locked -i tower-http -e normal --depth 2 confirms the remaining dependency is transitive through HTTP clients.
  • git diff --check passed.

Tracking

Parent cleanup task: #195.

Closes #195
Closes #196
Closes #197
Closes #198
Closes #199
Closes #200

Known Limitations

Standalone vp exec tsc --noEmit still fails due to the existing incomplete TypeScript type environment and other baseline diagnostics (2,826 before; 2,823 after). New component diagnostics come from the same missing React/JSX declarations. The repository quality command does not run this type check.

Database regressions requiring runtime configuration and ignored environment-dependent tests were not exercised against live PostgreSQL, Docker, or Chromium. No database schema or historical migration was changed.

Internal API compatibility changes are intentional: the repository owner confirmed there are no external consumers, including for the removed archive bytes API.

@yuanzui-cf
yuanzui-cf merged commit 39a7b35 into main Sep 12, 2026
3 checks passed
@yuanzui-cf
yuanzui-cf deleted the refactor/code-cleanup branch September 12, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant