refactor(core): Remove obsolete code and consolidate shared behavior - #201
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove obsolete internal APIs, unused dependencies, stale lint exemptions, and DNS challenge write paths left behind by the HTTP-01 transition. Compile the fake container runtime only for tests and simplify redundant runtime, migration-test, and Console route wrappers.
Share storage configuration parsing and Console field models, including consistent credential trimming. Centralize HTTP database/cache access and domain deletion: both deletion endpoints use the persisted deletion timestamp for quota idempotency, preserve administrator auditing, and attempt route invalidation even when cleanup encounters an infrastructure error.
Reuse Console setting switches, settings navigation, account-menu presentation/logout handling, and safe timestamp formatting. Keep navigation permissions with the calling layout and retain DNS ownership verification and protocol/security abstractions.
Validation
just qualitypassed before every commit: Rust formatting, Clippy, workspace tests/check/build, Console checks/tests/build, and license checks.cargo tree --locked -i tower-http -e normal --depth 2confirms the remaining dependency is transitive through HTTP clients.git diff --checkpassed.Tracking
Parent cleanup task: #195.
Closes #195
Closes #196
Closes #197
Closes #198
Closes #199
Closes #200
Known Limitations
Standalone
vp exec tsc --noEmitstill fails due to the existing incomplete TypeScript type environment and other baseline diagnostics (2,826 before; 2,823 after). New component diagnostics come from the same missing React/JSX declarations. The repository quality command does not run this type check.Database regressions requiring runtime configuration and ignored environment-dependent tests were not exercised against live PostgreSQL, Docker, or Chromium. No database schema or historical migration was changed.
Internal API compatibility changes are intentional: the repository owner confirmed there are no external consumers, including for the removed archive bytes API.