fix(node): Upload sparse files as regular entries - #194
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Projects containing sparse files fail before dependency installation because Docker rejects GNU sparse tar entries with
unhandled tar header type 83. Disable sparse encoding in the shared workspace/application upload helper so Docker receives regular file entries with the complete logical contents.Preserve symlink handling. Add regression coverage for both build and SSR archive roots, sparse and ordinary file contents, and symlinks pointing outside the source directory. Sparse files now occupy their logical size in upload archives.
Validation
cargo test -p grass-node runtime::socket::tests— passed (4 tests).just quality— passed (formatting, lint, Rust/Console tests and checks, builds, license checks).Tracking
Closes #193
Related deployment: #192; parent: #191.