Repository navigation
Add configurable conversation swipe actions - #409
sizzlesloth wants to merge 1 commit into
Conversation
RankoR
left a comment
There was a problem hiding this comment.
Please fix CI and add tests for the new code.
|
@RankoR the CI/CD failures seem like an AVD graphics issue, rather than an issue with my changes? Tests have also been added. Suppose I could add an additional test for the mapper if useful? |
|
@sizzlesloth no, there were failing tests:
They happen only on CI because of CI emu's screen size (320x640, 160 dpi). Also, please cleanup commits history:
|
00ef5b8 to
b7ef644
Compare
|
Thanks @RankoR , that's good to know. The |
850dd08 to
04a01a3
Compare
Combine swipe and selection flow for read/unread. Add jetpack stuff for the settings view. Add repo stuff for conversation swipe options. Split enums for ConversationSwipeOption and ConversationSwipeKind (model and UI). Impl mapper class. Use enum for conversation swipe prefs. Add tests and fix regressions. Formatting. Put block conversation ID and destination into dataclass. (the block ID and destination are always modified together, so easy win to pass detekt).
8fca009 to
8555740
Compare
|
Please add tests to the changed paths. See coverage report (for both unit and instrumented tests) for the new/changed code to find what should be tested. |
|
|
||
| import androidx.compose.runtime.Immutable | ||
| import com.android.messaging.data.appsettings.model.ConversationSwipeSettings | ||
| import com.android.messaging.ui.conversationlist.chats.mapper.toSwipeSpec |
There was a problem hiding this comment.
Model should not import from mapper. One fix option is to extract that extension to a proper place.
What is this?
This PR allows the left and right conversation swipe actions to be customised via the app's settings page.
Changes
Note: Most of my experience is with Java, so I am very new to Kotlin (and Jetpack compose). I found understanding the flow for deletion and other actions quite difficult, but I have tried my best to conform to how the existing archive and set read/unread behaviours work.
Tested on an emulator and on my Pixel 8 Pro. With both
mainand this branch, I get performance issues on the conversations screen, so I doubt these changes are the cause.Thanks!
mentions #351
closes #329