fix: surface useLandingStats loading/error state on the landing page (Closes #878) - #950
Open
waterWang wants to merge 1 commit into
Open
Conversation
…loses Grainlify#878) - WhyChooseUs now destructures isLoading, error, and refetch from useLandingStats() alongside display - Shows SkeletonLoader placeholders for stat values while loading - Shows inline Retry button on fetch failure that calls refetch - Added refetch function to useLandingStats hook for retry support - Updated Hero.test.tsx mock to include the new refetch field - 16 new + updated tests covering loading, success, error, and retry states
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Surface the
useLandingStatshooksisLoadinganderrorstates in theWhyChooseUssection of the landing page, replacing the silent—placeholder with proper loading indicators and error handling.Changes
useLandingStats.tsrefetchfunction (viauseCallback) so callers can re-trigger the fetch on demandLandingPage.tsxWhyChooseUsnow destructures{ display, isLoading, error, refetch }fromuseLandingStats()SkeletonLoaderplaceholdersrefetchGrants Distributedstat row (was previously missing from the display)SkeletonLoader,RefreshCw,DollarSignas neededLandingPage.test.tsxHero.test.tsxrefetch: vi.fn()to both mock return values to satisfy the updated typeVerification