Compare jdependency and R8 in minimization - #2280
Merged
Merged
Conversation
Goooler
force-pushed
the
g/20260903/document-r8
branch
from
September 3, 2026 11:58
ca29b14 to
7e6bcef
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The overview table currently implies unconditional SPI preservation for R8 and the PR description’s “Closes #2275” references a pull request rather than an issue, both of which should be corrected for accuracy/clarity.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates the minimization documentation to help users choose between Shadow’s built-in dependency analyzer (jdependency-based) and the R8 backend, clarifying tradeoffs and typical use cases.
Changes:
- Expands the introduction to describe minimization at the JAR/class/code level.
- Adds an “Overview & Choosing a Minimization Tool” section with a comparison table for
DEPENDENCY_ANALYZERvsR8. - Updates the exclusion guidance to mention Java SPI (
ServiceLoader) and adds a reference link to jdependency.
File summaries
| File | Description |
|---|---|
| docs/configuration/minimizing/README.md | Adds a tool-comparison overview and refines minimization guidance/links. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2275.