Convention sourceSetsClassesDirs in ShadowJavaPlugin and ShadowKmpPlugin - #2278
Closed
Goooler wants to merge 1 commit into
Closed
Convention sourceSetsClassesDirs in ShadowJavaPlugin and ShadowKmpPlugin#2278Goooler wants to merge 1 commit into
Goooler wants to merge 1 commit into
Conversation
Goooler
force-pushed
the
g/20260903/init-sources-dirs-for-each
branch
from
September 3, 2026 10:31
045b4b8 to
e07ef76
Compare
Goooler
force-pushed
the
g/20260903/init-sources-dirs-for-each
branch
from
September 3, 2026 10:37
e07ef76 to
950b79e
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new conventions are applied unconditionally (adding avoidable inputs/dependencies when minimization is off) and the task default becoming empty can silently break minimization for custom ShadowJar tasks.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR shifts responsibility for setting ShadowJar.sourceSetsClassesDirs from the ShadowJar task itself to the plugins (ShadowJavaPlugin and ShadowKmpPlugin), with the intent of standardizing how minimization roots are derived (including test outputs).
Changes:
ShadowJar.sourceSetsClassesDirsis no longer lazily populated based onminimizeJar; it is now an emptyConfigurableFileCollectionby default.ShadowJavaPluginconventionssourceSetsClassesDirsfrom all JavasourceSetsoutputs (includingtest).ShadowKmpPluginconventionssourceSetsClassesDirsfrom all Kotlin/JVM target compilations outputs (includingtest).
File summaries
| File | Description |
|---|---|
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowJar.kt |
Removes built-in lazy default population for sourceSetsClassesDirs. |
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowKmpPlugin.kt |
Adds plugin-side convention for sourceSetsClassesDirs from KMP compilations. |
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowJavaPlugin.kt |
Adds plugin-side convention for sourceSetsClassesDirs from Java source sets. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| } | ||
| } | ||
| } | ||
| public open val sourceSetsClassesDirs: ConfigurableFileCollection = objectFactory.fileCollection() |
Member
Author
There was a problem hiding this comment.
You are right! This is a potential breaking change for users who register the task by themselves.
Comment on lines
+46
to
+50
| // Include all source sets (including test) so that test code's transitive dependency | ||
| // references are also considered "used" during minimization. | ||
| task.sourceSetsClassesDirs.convention( | ||
| sourceSets.map { it.output.classesDirs.filter(File::isDirectory) } | ||
| ) |
Comment on lines
+44
to
+50
| // Include all compilations (including test) so that test code's transitive dependency | ||
| // references are also considered "used" during minimization. | ||
| task.sourceSetsClassesDirs.convention( | ||
| target.compilations.map { compilation -> | ||
| compilation.output.classesDirs.filter { it.isDirectory } | ||
| } | ||
| ) |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #2276.