Clean up loggings - #2273
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are limited to logging cleanup and corresponding test adjustments, with no evident behavioral regressions.
Pull request overview
This PR refines logging behavior across the Shadow plugin and its tasks to reduce noise while keeping useful diagnostics, and updates functional tests accordingly.
Changes:
- Add targeted
debuglogs for included dependencies and resource transformations to aid troubleshooting without increasing default verbosity. - Simplify several conditional logging branches (early-returns instead of “skipping …” info logs).
- Adjust manifest-attribute logging to be more accurate and update functional tests to stop asserting on log output.
File summaries
| File | Description |
|---|---|
| src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowJar.kt | Reduces/clarifies task logging (minimization, dependency inclusion, manifest attribute messages) while keeping behavior consistent. |
| src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowCopyAction.kt | Adds debug visibility into which transformer handled a given resource. |
| src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowPlugin.kt | Removes “skipping” info log for Develocity integration and simplifies control flow. |
| src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/JavaPluginsTest.kt | Stops asserting on log output; keeps validating resulting manifest behavior instead. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.