Fix heredoc terminator in create-release skill - #15
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe release skill documentation reformats the Step 5 ChangesRelease Documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the release creation skill documentation (SKILL.md) to fix nested markdown code block formatting by using quadruple backticks and removing unnecessary indentation. The review feedback suggests a valuable improvement to the gh release create command, recommending the use of --notes-file - with a standard heredoc instead of a subshell with cat to simplify the syntax and avoid spawning an extra process.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
Pull request overview
This PR updates the create-release skill documentation so the gh release create ... --notes "$(cat <<'EOF' ... EOF)" heredoc is copy/paste-safe by ensuring the EOF terminator is at column 0 and by using an outer four-backtick fence to safely include a nested ```bash block.
Changes:
- Dedented the
gh release createexample so the heredoc terminator (EOF) is unindented and closes correctly in bash. - Switched the outer code fence to ````bash to avoid prematurely closing due to the nested ```bash install snippet.
- Normalized the release-notes body indentation to match the now-unindented heredoc content.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
The
gh release createblock in.claude/skills/create-release/SKILL.mdwas indented under the numbered list, which put the closingEOF(and the whole--notes "$(cat <<'EOF' … EOF)"body) at a non-zero column. Bash only treats a<<'EOF'heredoc as closed when the terminator line has no leading whitespace, so a literal copy-paste of that command wouldn't close the heredoc — it would swallow theEOFline and corrupt the release notes.Fixed by dedenting the release block to column 0 and switching the outer fence to four backticks (so the nested
```bashinstall block doesn't close it early), matching the already-correctideandPullUpcreate-release skills. Terminator now sits at column 0.Test plan
grep -n '^EOF$'confirms the terminator is at column 0.Summary by CodeRabbit