fix: handle empty PLATFORM_ARGS array under bash set -u#35
Merged
ptone merged 1 commit intoGoogleCloudPlatform:mainfrom Apr 10, 2026
Merged
Conversation
${array[@]} with set -euo pipefail fails when the array is empty on
some bash versions. Use the ${array[@}+"${array[@]}"} idiom to expand
only when the array is non-empty.
scion-gteam Bot
pushed a commit
to ptone/scion
that referenced
this pull request
Apr 12, 2026
…latform#35) ${array[@]} with set -euo pipefail fails when the array is empty on some bash versions. Use the ${array[@}+"${array[@]}"} idiom to expand only when the array is non-empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build-images.shusesset -euo pipefail, which causes${PLATFORM_ARGS[@]}to fail with "unbound variable" when no--platformflag is passed and the array is emptydocker buildx buildcall sites using the${array[@]+"${array[@]}"}idiom, which expands only when the array is non-emptyTest plan
build-images.sh --registry local/test --target core-basenow runs without error (previously failed immediately with unbound variable)--platformflag still works correctly when provided