Skip to content

refactor: extract flattenServiceAccountKey from Read function#18241

Open
vr-ibm wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
vr-ibm:service-account-key-flatten-refactor
Open

refactor: extract flattenServiceAccountKey from Read function#18241
vr-ibm wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
vr-ibm:service-account-key-flatten-refactor

Conversation

@vr-ibm

@vr-ibm vr-ibm commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Extracts the field-setting logic from resourceGoogleServiceAccountKeyRead into a shared flattenServiceAccountKey function. This enables reuse by the upcoming list resource (#18242) without duplicating code.
No behavior change, pure refactor.

Details

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/iam-serviceaccount and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jul 9, 2026
@modular-magician

modular-magician commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 044e576:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 5 insertions(+), 1 deletion(-)
google-beta provider View Diff 1 file changed, 5 insertions(+), 1 deletion(-)

Test report

Analytics

Total Tests Passed Skipped Affected
183 152 31 0
Affected Service Packages
  • resourcemanager

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@vr-ibm VCR tests complete for 044e576!

@vr-ibm vr-ibm marked this pull request as ready for review July 9, 2026 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants