discoveryengine: add enable_llm_layout_parsing and enable_get_processed_document to data store#18239
Conversation
…ed_document to data store
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 5f76e7e: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_discovery_engine_data_store" "primary" {
document_processing_config {
parsing_config_overrides {
layout_parsing_config {
enable_get_processed_document = # value needed
enable_llm_layout_parsing = # value needed
}
}
}
}
Missing doc report (experimental)The following resources have fields missing in documents.
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @JonathanvanWestendorp, @BBBmau VCR tests complete for 5f76e7e! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d4c7c65: Diff reportYour PR generated the following diffs in downstream repositories:
Missing doc report (experimental)The following resources have fields missing in documents.
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @JonathanvanWestendorp, @BBBmau VCR tests complete for d4c7c65! |
BBBmau
left a comment
There was a problem hiding this comment.
LGTM just address the comment i have and i can approve and merge.
The failing test is urnelated as well as it failing for quite a while based on the nightly-test history
| type: Boolean | ||
| description: | | ||
| If true, the pdf layout will be refined using an LLM. | ||
| required: false |
There was a problem hiding this comment.
this doesn't need to be set since by default fields are set to be optional
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit bd63e46: Diff reportYour PR generated the following diffs in downstream repositories:
Missing doc report (experimental)The following resources have fields missing in documents.
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @JonathanvanWestendorp, @BBBmau VCR tests complete for bd63e46! |
7bcf609
Adds the two remaining GA
layout_parsing_configfields togoogle_discovery_engine_data_storeso the block matches the v1 API:enable_llm_layout_parsing— if true, the PDF layout is refined using an LLM.enable_get_processed_document— if true, the processed document is made available for the GetProcessedDocument API.Both are added to
default_parsing_config.layout_parsing_configand the per-file-typeparsing_config_overridesblock, and exercised in thedocument_processing_config_layout_fullexample. Both fields exist in thev1(GA) discovery doc.