Skip to content

initial write-only breaking change#18232

Draft
BBBmau wants to merge 1 commit into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-8.0.0from
BBBmau:mmv1-write-only-legacy-major-migration
Draft

initial write-only breaking change#18232
BBBmau wants to merge 1 commit into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-8.0.0from
BBBmau:mmv1-write-only-legacy-major-migration

Conversation

@BBBmau

@BBBmau BBBmau commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

simplify write-only (WIP changelog)

@modular-magician

modular-magician commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 16bea9c:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 9 files changed, 67 insertions(+), 74 deletions(-)
google-beta provider View Diff 9 files changed, 67 insertions(+), 74 deletions(-)
terraform-google-conversion View Diff 8 files changed, 10 insertions(+), 121 deletions(-)

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field http_check.auth_info.password_wo within resource google_monitoring_uptime_check_config was added to exactly one of - reference
  • Field http_check.auth_info.password within resource google_monitoring_uptime_check_config was added to exactly one of - reference
  • Field secret_data_wo_version changed from TypeInt to TypeString on google_secret_manager_secret_version - reference
  • Field secret_data_wo_version default value changed from 0 to <nil> on google_secret_manager_secret_version - reference
  • Field sensitive_params.secret_access_key_wo_version changed from TypeInt to TypeString on google_bigquery_data_transfer_config - reference
  • Field sensitive_params.secret_access_key_wo within resource google_bigquery_data_transfer_config was added to exactly one of - reference
  • Field sensitive_params.secret_access_key within resource google_bigquery_data_transfer_config was added to exactly one of - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_bigquery_data_transfer_config (12 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigquery_data_transfer_config" "primary" {
  sensitive_params {
    secret_access_key            = # value needed
    secret_access_key_wo         = # value needed
    secret_access_key_wo_version = # value needed
  }
}

Test report

Analytics

Total Tests Passed Skipped Affected
107 96 8 3
Affected Service Packages
  • bigquerydatatransfer
  • monitoring
  • secretmanager

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccDatasourceSecretManagerSecretVersion_basic
  • TestAccMonitoringUptimeCheckConfig_update_wo
  • TestAccMonitoringUptimeCheckConfig_uptimeCheckConfigHttpPasswordWoExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccDatasourceSecretManagerSecretVersion_basic
✅ Log TestAccMonitoringUptimeCheckConfig_update_wo
✅ Log TestAccMonitoringUptimeCheckConfig_uptimeCheckConfigHttpPasswordWoExample

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@BBBmau, @sachinpro VCR tests complete for 16bea9c!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants