Skip to content

discoveryengine: add list resources#18231

Draft
BBBmau wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
BBBmau:add-discoveryengine-list-resources
Draft

discoveryengine: add list resources#18231
BBBmau wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
BBBmau:add-discoveryengine-list-resources

Conversation

@BBBmau

@BBBmau BBBmau commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

What this PR does

Enables MMv1 list resource generation for all Discovery Engine MMv1 resources by adding generate_list_resource: true to each Discovery Engine product resource YAML.

Discovery Engine resources with list support added

  • google_discovery_engine_acl_config
  • google_discovery_engine_assistant
  • google_discovery_engine_chat_engine
  • google_discovery_engine_cmek_config
  • google_discovery_engine_control
  • google_discovery_engine_data_connector
  • google_discovery_engine_data_store
  • google_discovery_engine_license_config
  • google_discovery_engine_recommendation_engine
  • google_discovery_engine_schema
  • google_discovery_engine_search_engine
  • google_discovery_engine_serving_config
  • google_discovery_engine_sitemap
  • google_discovery_engine_target_site
  • google_discovery_engine_user_store
  • google_discovery_engine_widget_config

Notes

  • Scope is limited to mmv1/products/discoveryengine/*.yaml resources.
  • No behavior changes were made outside Discovery Engine MMv1 resource metadata.
`google_discovery_engine_acl_config`
`google_discovery_engine_assistant`
`google_discovery_engine_chat_engine`
`google_discovery_engine_cmek_config`
`google_discovery_engine_control`
`google_discovery_engine_data_connector`
`google_discovery_engine_data_store`
`google_discovery_engine_license_config`
`google_discovery_engine_recommendation_engine`
`google_discovery_engine_schema`
`google_discovery_engine_search_engine`
`google_discovery_engine_serving_config`
`google_discovery_engine_sitemap`
`google_discovery_engine_target_site`
`google_discovery_engine_user_store`
`google_discovery_engine_widget_config`

@modular-magician

modular-magician commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit ff70227:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 44 files changed, 5348 insertions(+)
google-beta provider View Diff 44 files changed, 5348 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
55 38 4 13
Affected Service Packages
  • discoveryengine

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 13 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccDiscoveryEngineAclConfigListQuery_generated
  • TestAccDiscoveryEngineAssistantListQuery_generated
  • TestAccDiscoveryEngineChatEngineListQuery_generated
  • TestAccDiscoveryEngineControlListQuery_generated
  • TestAccDiscoveryEngineDataConnectorListQuery_generated
  • TestAccDiscoveryEngineDataStoreListQuery_generated
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccDiscoveryEngineRecommendationEngineListQuery_generated
  • TestAccDiscoveryEngineSchemaListQuery_generated
  • TestAccDiscoveryEngineSearchEngineListQuery_generated
  • TestAccDiscoveryEngineSitemapListQuery_generated
  • TestAccDiscoveryEngineTargetSiteListQuery_generated
  • TestAccDiscoveryEngineWidgetConfigListQuery_generated

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccDiscoveryEngineAssistantListQuery_generated
✅ Log TestAccDiscoveryEngineDataStoreListQuery_generated
✅ Log TestAccDiscoveryEngineSchemaListQuery_generated
✅ Log TestAccDiscoveryEngineTargetSiteListQuery_generated
❌ Error · Log - TestAccDiscoveryEngineAclConfigListQuery_generated
❌ Error · Log - TestAccDiscoveryEngineChatEngineListQuery_generated
❌ Error · Log - TestAccDiscoveryEngineControlListQuery_generated
❌ Error · Log - TestAccDiscoveryEngineDataConnectorListQuery_generated
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccDiscoveryEngineRecommendationEngineListQuery_generated
❌ Error · Log - TestAccDiscoveryEngineSearchEngineListQuery_generated
❌ Error · Log - TestAccDiscoveryEngineSitemapListQuery_generated
❌ Error · Log - TestAccDiscoveryEngineWidgetConfigListQuery_generated

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@BBBmau VCR tests complete for ff70227!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants