Skip to content

test: Fix flaky Firestore Timestamp field test #18227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bw-yuhogg wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: Fix flaky Firestore Timestamp field test #18227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions mmv1/templates/terraform/custom_check_destroy/firestore_field.go.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ if err != nil {
// We do not return the error in this case - destroy was successful
return nil
}
if e.Code == 404 && regexp.MustCompile(`Project .* or database .* does not exist`).MatchString(e.Message) {
// The project or database does not exist, which means the resource is destroyed.
return nil
}

// Return err in all other cases
return err
Expand Down
2 changes: 2 additions & 0 deletions mmv1/templates/terraform/samples/base_configs/test_file.go.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ package {{ $.Res.PackageName }}_test
import (
"fmt"
"log"
"regexp"
"strconv"
"strings"
"testing"
Expand Down Expand Up @@ -59,6 +60,7 @@ import (
var (
_ = fmt.Sprintf
_ = log.Print
_ = regexp.MatchString
_ = strconv.Atoi
_ = strings.Trim
_ = time.Now
Expand Down