Promote NCC Gateway Spokes and Gateway Advertised Routes to General A…

[abhijeetkjha-google]

This PR promotes the gateway block on google_network_connectivity_spoke, the ncc_gateway attribute on google_compute_router, and the standalone google_network_connectivity_gateway_advertised_route resource from Beta to GA. It also updates the reference documentation links, sample templates, and acceptance test generator wrappers for full GA compatibility.

Fixes: b/531557361
Reference Beta PR: #15198

networkconnectivity: promoted `gateway` field in `google_network_connectivity_spoke` to GA
networkconnectivity: promoted `google_network_connectivity_gateway_advertised_route` resource to GA
compute: promoted `ncc_gateway` field in `google_compute_router` to GA

[github-actions]

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@malhotrasagar2212, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 8dd4242:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	13 files changed, 1646 insertions(+), 29 deletions(-)
google-beta provider	View Diff	6 files changed, 7 insertions(+), 37 deletions(-)
terraform-google-conversion	View Diff	4 files changed, 49 insertions(+), 1 deletion(-)
Open in Cloud Shell	View Diff	12 files changed, 444 insertions(+)

Test report

Important

Manual Verification Required (GA-only additions)

The following tests are GA-only additions and cannot be run by VCR in Beta mode. Please verify them manually:

🔴 TestAccComputeRouter_routerNccGwExample
🔴 TestAccNetworkConnectivityGatewayAdvertisedRoute_networkConnectivityGatewayAdvertisedRouteBasicExample
🔴 TestAccNetworkConnectivityGatewayAdvertisedRouter_test_basic
🔴 TestAccNetworkConnectivitySpoke_networkConnectivitySpokeGatewayExample

Analytics

Total Tests	Passed	Skipped	Affected
1549	1454	95	0

Affected Service Packages

• compute
• networkconnectivity

Learn how VCR tests work

---

Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

Caution

Issues requiring attention before PR completion

🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the replaying VCR build log

@abhijeetkjha-google, @malhotrasagar2212 VCR tests complete for 8dd4242!