Add Google Cloud Network Connectivity CustomHardwareLinkConnectPair resource#18218
Add Google Cloud Network Connectivity CustomHardwareLinkConnectPair resource#18218shengquan-ni wants to merge 2 commits into
Conversation
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 4756d11: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @shengquan-ni, @slevenick VCR tests complete for 4756d11! |
4756d11 to
abeb89d
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit abeb89d: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportImportant Manual Verification Required VCR cannot automatically execute the following tests added in this PR. Please verify them manually: 🔴 TestAccNetworkConnectivityCustomHardwareLinkConnectPair_networkConnectivityCustomHardwareLinkConnectPairBasicExample Analytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. Caution Issues requiring attention before PR completion 🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the replaying VCR build log @shengquan-ni, @slevenick VCR tests complete for abeb89d! |
abeb89d to
2ad4f50
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 2ad4f50: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @shengquan-ni, @slevenick VCR tests complete for 2ad4f50! |
slevenick
left a comment
There was a problem hiding this comment.
Please do a local review with a Google engineer from the service team as described at go/terraform-service-review. Let me know when that's finished and I'll follow up with final review & merge.
Please also fix the tests
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit dcb13db: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @shengquan-ni, @slevenick VCR tests complete for dcb13db! |
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.
Part of hashicorp/terraform-provider-google#27551