Skip to content

Add Google Cloud Network Connectivity CustomHardwareLinkConnectPair resource#18218

Open
shengquan-ni wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
shengquan-ni:add-custom-hardware-lcp
Open

Add Google Cloud Network Connectivity CustomHardwareLinkConnectPair resource#18218
shengquan-ni wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
shengquan-ni:add-custom-hardware-lcp

Conversation

@shengquan-ni

Copy link
Copy Markdown
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

Part of hashicorp/terraform-provider-google#27551

`google_network_connectivity_custom_hardware_link_connect_pair`

@github-actions github-actions Bot requested a review from slevenick July 7, 2026 21:39
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

modular-magician commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 4756d11:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 224 insertions(+)
google-beta provider View Diff 5 files changed, 1555 insertions(+)
terraform-google-conversion View Diff 1 file changed, 172 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
43 40 1 2
Affected Service Packages
  • networkconnectivity

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccNetworkConnectivityCustomHardwareLinkConnectPair_networkConnectivityCustomHardwareLinkConnectPairBasicExample
  • TestAccNetworkConnectivityCustomHardwareLinkConnectPair_networkConnectivityCustomHardwareLinkConnectPairUllExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccNetworkConnectivityCustomHardwareLinkConnectPair_networkConnectivityCustomHardwareLinkConnectPairBasicExample
❌ Error · Log - TestAccNetworkConnectivityCustomHardwareLinkConnectPair_networkConnectivityCustomHardwareLinkConnectPairUllExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@shengquan-ni, @slevenick VCR tests complete for 4756d11!

@shengquan-ni shengquan-ni force-pushed the add-custom-hardware-lcp branch from 4756d11 to abeb89d Compare July 7, 2026 21:57
@modular-magician

modular-magician commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit abeb89d:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 224 insertions(+)
google-beta provider View Diff 5 files changed, 1559 insertions(+)
terraform-google-conversion View Diff 1 file changed, 172 insertions(+)

Test report

Important

Manual Verification Required

VCR cannot automatically execute the following tests added in this PR. Please verify them manually:

🔴 TestAccNetworkConnectivityCustomHardwareLinkConnectPair_networkConnectivityCustomHardwareLinkConnectPairBasicExample
🔴 TestAccNetworkConnectivityCustomHardwareLinkConnectPair_networkConnectivityCustomHardwareLinkConnectPairUllExample

Analytics

Total Tests Passed Skipped Affected
43 40 3 0
Affected Service Packages
  • networkconnectivity

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

Caution

Issues requiring attention before PR completion

🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the replaying VCR build log

@shengquan-ni, @slevenick VCR tests complete for abeb89d!

@shengquan-ni shengquan-ni force-pushed the add-custom-hardware-lcp branch from abeb89d to 2ad4f50 Compare July 8, 2026 18:08
@modular-magician

modular-magician commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 2ad4f50:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 224 insertions(+)
google-beta provider View Diff 5 files changed, 1555 insertions(+)
terraform-google-conversion View Diff 1 file changed, 172 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
43 40 1 2
Affected Service Packages
  • networkconnectivity

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccNetworkConnectivityCustomHardwareLinkConnectPair_networkConnectivityCustomHardwareLinkConnectPairBasicExample
  • TestAccNetworkConnectivityCustomHardwareLinkConnectPair_networkConnectivityCustomHardwareLinkConnectPairUllExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccNetworkConnectivityCustomHardwareLinkConnectPair_networkConnectivityCustomHardwareLinkConnectPairBasicExample
❌ Error · Log - TestAccNetworkConnectivityCustomHardwareLinkConnectPair_networkConnectivityCustomHardwareLinkConnectPairUllExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@shengquan-ni, @slevenick VCR tests complete for 2ad4f50!

@slevenick slevenick left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do a local review with a Google engineer from the service team as described at go/terraform-service-review. Let me know when that's finished and I'll follow up with final review & merge.

Please also fix the tests

@github-actions github-actions Bot requested a review from slevenick July 9, 2026 21:59
@modular-magician

modular-magician commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit dcb13db:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 224 insertions(+)
google-beta provider View Diff 5 files changed, 1555 insertions(+)
terraform-google-conversion View Diff 1 file changed, 172 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
43 40 1 2
Affected Service Packages
  • networkconnectivity

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccNetworkConnectivityCustomHardwareLinkConnectPair_networkConnectivityCustomHardwareLinkConnectPairBasicExample
  • TestAccNetworkConnectivityCustomHardwareLinkConnectPair_networkConnectivityCustomHardwareLinkConnectPairUllExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccNetworkConnectivityCustomHardwareLinkConnectPair_networkConnectivityCustomHardwareLinkConnectPairBasicExample
❌ Error · Log - TestAccNetworkConnectivityCustomHardwareLinkConnectPair_networkConnectivityCustomHardwareLinkConnectPairUllExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@shengquan-ni, @slevenick VCR tests complete for dcb13db!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants