Skip to content

Expose GKE desired_emulated_version update trigger in Cluster resource#17765

Open
ChinemeremChigbo wants to merge 12 commits into
GoogleCloudPlatform:mainfrom
ChinemeremChigbo:gke-desired-emulated-version
Open

Expose GKE desired_emulated_version update trigger in Cluster resource#17765
ChinemeremChigbo wants to merge 12 commits into
GoogleCloudPlatform:mainfrom
ChinemeremChigbo:gke-desired-emulated-version

Conversation

@ChinemeremChigbo

@ChinemeremChigbo ChinemeremChigbo commented May 29, 2026

Copy link
Copy Markdown
Member

Exposes GKE support for declaratively completing GKE rollback-safe minor control plane upgrades in the google-beta provider:

  • desired_emulated_version (Optional): Write-only trigger field (no flattener) to complete upgrades.
  • emulated_version (Computed): Read-only status field returning the active emulated version.
  • Testing: Added E2E acceptance test TestAccContainerCluster_desiredEmulatedVersion (3-step soak upgrade) with live GKE REST API validation.

Release Note Template for Downstream PRs (will be copied)

container: added `desired_emulated_version` and `emulated_version` fields to `google_container_cluster` resource (beta)

@modular-magician

modular-magician commented May 29, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 90e73c2:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 150 insertions(+)
google-beta provider View Diff 2 files changed, 180 insertions(+)
terraform-google-conversion View Diff 1 file changed, 3 insertions(+)

Errors

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

Step 1: Replaying Mode

Caution

Build Failure during VCR tests

🔴 REPLAYING mode: The following packages failed to build:

  • container

Please fix the compilation errors to complete your PR.

View the build log

@ChinemeremChigbo VCR tests complete for 90e73c2!

@ChinemeremChigbo ChinemeremChigbo force-pushed the gke-desired-emulated-version branch from 90e73c2 to 06637fa Compare May 29, 2026 09:36
@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@ChinemeremChigbo ChinemeremChigbo marked this pull request as ready for review June 23, 2026 20:27
@github-actions github-actions Bot requested a review from melinath June 23, 2026 20:28
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

modular-magician commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 3e9a5cb:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 8 insertions(+)
google-beta provider View Diff 3 files changed, 298 insertions(+)
terraform-google-conversion View Diff 1 file changed, 6 insertions(+)

Errors

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

Step 1: Replaying Mode

Caution

Build Failure during VCR tests

🔴 REPLAYING mode: The following packages failed to build:

  • container

Please fix the compilation errors to complete your PR.

View the build log

@ChinemeremChigbo, @melinath VCR tests complete for 3e9a5cb!

@melinath melinath left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor changes, and it looks like this also requires updating the client library version - this should happen in a separate PR. See https://googlecloudplatform.github.io/magic-modules/develop/update-dependencies/

Comment thread mmv1/third_party/terraform/website/docs/r/container_cluster.html.markdown Outdated
Comment thread mmv1/third_party/terraform/website/docs/r/container_cluster.html.markdown Outdated
@github-actions github-actions Bot requested a review from melinath June 24, 2026 21:47

@melinath melinath left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

marking as changes requested again due to the dependency upgrade.

@modular-magician

modular-magician commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 340f91a:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 8 insertions(+)
google-beta provider View Diff 3 files changed, 298 insertions(+)
terraform-google-conversion View Diff 1 file changed, 6 insertions(+)

Errors

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

Step 1: Replaying Mode

Caution

Build Failure during VCR tests

🔴 REPLAYING mode: The following packages failed to build:

  • container

Please fix the compilation errors to complete your PR.

View the build log

@ChinemeremChigbo VCR tests complete for 340f91a!

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

@ChinemeremChigbo, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

This notification can be disabled with the disable-automatic-closure label.

@github-actions github-actions Bot requested a review from melinath July 9, 2026 18:08
@modular-magician

modular-magician commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b1002a5:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 8 insertions(+)
google-beta provider View Diff 3 files changed, 298 insertions(+)
terraform-google-conversion View Diff 1 file changed, 6 insertions(+)

Errors

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

Step 1: Replaying Mode

Caution

Build Failure during VCR tests

🔴 REPLAYING mode: The following packages failed to build:

  • container

Please fix the compilation errors to complete your PR.

View the build log

@ChinemeremChigbo, @melinath VCR tests complete for b1002a5!

@modular-magician

modular-magician commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit fe72570:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 8 insertions(+)
google-beta provider View Diff 3 files changed, 298 insertions(+)
terraform-google-conversion View Diff 1 file changed, 6 insertions(+)

Errors

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

Step 1: Replaying Mode

Caution

Build Failure during VCR tests

🔴 REPLAYING mode: The following packages failed to build:

  • container

Please fix the compilation errors to complete your PR.

View the build log

@ChinemeremChigbo, @melinath VCR tests complete for fe72570!

@ChinemeremChigbo

Copy link
Copy Markdown
Member Author

The dependency PR is here: #18246

@ChinemeremChigbo ChinemeremChigbo force-pushed the gke-desired-emulated-version branch from fe72570 to cf92713 Compare July 9, 2026 23:47
@modular-magician

modular-magician commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit cf92713:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 266 insertions(+)
google-beta provider View Diff 3 files changed, 298 insertions(+)
terraform-google-conversion View Diff 1 file changed, 6 insertions(+)

Errors

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

Step 1: Replaying Mode

Caution

Build Failure during VCR tests

🔴 REPLAYING mode: The following packages failed to build:

  • container

Please fix the compilation errors to complete your PR.

View the build log

@ChinemeremChigbo, @melinath VCR tests complete for cf92713!

ChinemeremChigbo and others added 4 commits July 10, 2026 17:34
…ml.markdown

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
…ml.markdown

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
@ChinemeremChigbo ChinemeremChigbo force-pushed the gke-desired-emulated-version branch from cf92713 to 30bfb20 Compare July 10, 2026 17:36
@modular-magician

modular-magician commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 30bfb20:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 288 insertions(+)
google-beta provider View Diff 3 files changed, 346 insertions(+)
terraform-google-conversion View Diff 1 file changed, 6 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
319 301 14 4
Affected Service Packages
  • container

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccContainerCluster_desiredEmulatedVersion
  • TestAccContainerCluster_desiredEmulatedVersionAutopilot
  • TestAccContainerCluster_regionalWithNodePool
  • TestAccContainerNodePool_withHostMaintenancePolicy

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccContainerCluster_desiredEmulatedVersion
❌ Error · Log - TestAccContainerCluster_desiredEmulatedVersionAutopilot
❌ Error · Log - TestAccContainerCluster_regionalWithNodePool
❌ Error · Log - TestAccContainerNodePool_withHostMaintenancePolicy

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@ChinemeremChigbo, @melinath VCR tests complete for 30bfb20!

@modular-magician

modular-magician commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit c84c6c6:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 288 insertions(+)
google-beta provider View Diff 4 files changed, 352 insertions(+)
terraform-google-conversion View Diff 1 file changed, 6 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
319 301 14 4
Affected Service Packages
  • container

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccContainerCluster_desiredEmulatedVersion
  • TestAccContainerCluster_desiredEmulatedVersionAutopilot
  • TestAccContainerCluster_regionalWithNodePool
  • TestAccContainerNodePool_withHostMaintenancePolicy

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccContainerCluster_desiredEmulatedVersion
❌ Error · Log - TestAccContainerCluster_desiredEmulatedVersionAutopilot
❌ Error · Log - TestAccContainerCluster_regionalWithNodePool
❌ Error · Log - TestAccContainerNodePool_withHostMaintenancePolicy

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@ChinemeremChigbo, @melinath VCR tests complete for c84c6c6!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants