Expose GKE desired_emulated_version update trigger in Cluster resource#17765
Expose GKE desired_emulated_version update trigger in Cluster resource#17765ChinemeremChigbo wants to merge 12 commits into
Conversation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 90e73c2: Diff reportYour PR generated the following diffs in downstream repositories:
Errors
Step 1: Replaying Mode Caution Build Failure during VCR tests 🔴 REPLAYING mode: The following packages failed to build:
Please fix the compilation errors to complete your PR. View the build log @ChinemeremChigbo VCR tests complete for 90e73c2! |
90e73c2 to
06637fa
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 3e9a5cb: Diff reportYour PR generated the following diffs in downstream repositories:
Errors
Step 1: Replaying Mode Caution Build Failure during VCR tests 🔴 REPLAYING mode: The following packages failed to build:
Please fix the compilation errors to complete your PR. View the build log @ChinemeremChigbo, @melinath VCR tests complete for 3e9a5cb! |
melinath
left a comment
There was a problem hiding this comment.
A couple minor changes, and it looks like this also requires updating the client library version - this should happen in a separate PR. See https://googlecloudplatform.github.io/magic-modules/develop/update-dependencies/
melinath
left a comment
There was a problem hiding this comment.
marking as changes requested again due to the dependency upgrade.
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 340f91a: Diff reportYour PR generated the following diffs in downstream repositories:
Errors
Step 1: Replaying Mode Caution Build Failure during VCR tests 🔴 REPLAYING mode: The following packages failed to build:
Please fix the compilation errors to complete your PR. View the build log @ChinemeremChigbo VCR tests complete for 340f91a! |
|
@ChinemeremChigbo, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days. Please address any comments or change requests, or re-request review from a core reviewer if no action is required. This notification can be disabled with the |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b1002a5: Diff reportYour PR generated the following diffs in downstream repositories:
Errors
Step 1: Replaying Mode Caution Build Failure during VCR tests 🔴 REPLAYING mode: The following packages failed to build:
Please fix the compilation errors to complete your PR. View the build log @ChinemeremChigbo, @melinath VCR tests complete for b1002a5! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit fe72570: Diff reportYour PR generated the following diffs in downstream repositories:
Errors
Step 1: Replaying Mode Caution Build Failure during VCR tests 🔴 REPLAYING mode: The following packages failed to build:
Please fix the compilation errors to complete your PR. View the build log @ChinemeremChigbo, @melinath VCR tests complete for fe72570! |
|
The dependency PR is here: #18246 |
fe72570 to
cf92713
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit cf92713: Diff reportYour PR generated the following diffs in downstream repositories:
Errors
Step 1: Replaying Mode Caution Build Failure during VCR tests 🔴 REPLAYING mode: The following packages failed to build:
Please fix the compilation errors to complete your PR. View the build log @ChinemeremChigbo, @melinath VCR tests complete for cf92713! |
…ml.markdown Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
…ml.markdown Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
cf92713 to
30bfb20
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 30bfb20: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @ChinemeremChigbo, @melinath VCR tests complete for 30bfb20! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit c84c6c6: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @ChinemeremChigbo, @melinath VCR tests complete for c84c6c6! |

Exposes GKE support for declaratively completing GKE rollback-safe minor control plane upgrades in the
google-betaprovider:desired_emulated_version(Optional): Write-only trigger field (no flattener) to complete upgrades.emulated_version(Computed): Read-only status field returning the active emulated version.TestAccContainerCluster_desiredEmulatedVersion(3-step soak upgrade) with live GKE REST API validation.Release Note Template for Downstream PRs (will be copied)