chore: Adding erlanderlo as dataflow maintainers#3409
Conversation
guilherme-hosoda-cit
requested review from
apeabody,
bharathkkb,
g-awmalik and
q2w
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the maintainers list for the Dataflow job configuration in the Terraform locals file by adding a new user. The review feedback suggests using setunion() instead of concat() to ensure the resulting list contains unique entries and avoids potential duplicates.
| description = "Handles opinionated Dataflow job configuration and deployments" | ||
| topics = local.common_topics.da | ||
| maintainers = local.adc_common_admins | ||
| maintainers = concat(["erlanderlo"], local.adc_common_admins) |
There was a problem hiding this comment.
When combining lists where uniqueness is desired, use setunion() instead of concat() to automatically handle and prevent duplicate entries.
maintainers = setunion(["erlanderlo"], local.adc_common_admins)
References
- When combining lists where uniqueness is desired, use
setunion()instead ofconcat()to automatically handle and prevent duplicate entries.
There was a problem hiding this comment.
Do I need to make this modification? I understand its purpose, but using concat is standard in this file.
There was a problem hiding this comment.
Also this value is used to define a value for a set variable, that already removes duplicated entries.
|
@erlanderlo could you take a look at this PR? |
1 participant
This PR adds @erlanderlo as one of the
terraform-google-dataflowmaintainers.