Skip to content

chore: adding cas terraform module #3393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vandnagarggoogle wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: adding cas terraform module #3393

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09ae2a4
adding cas terraform module
vandnagarggoogle Mar 23, 2026
eb2a2e9
adding space lint
vandnagarggoogle Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions infra/terraform/test-org/org/locals.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1037,5 +1037,14 @@ locals {
ENABLE_BPMETADATA = "1"
}
},
{
name = "terraform-google-certificate-authority-service"
org = "GoogleCloudPlatform"
description = "Create and manage CAS"
maintainers = setunion(["viojha96", "vandnagarggoogle"], local.adc_common_admins)
lint_env = {
ENABLE_BPMETADATA = "1"
}
},
Comment on lines +1040 to +1048
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The repos schema definition (lines 60-76) indicates that the topics attribute is required for modules (when module is true, which is the default). This new module definition is missing the topics attribute. Based on the module's name and description, the "security-identity" topic seems appropriate.

    {
      name        = "terraform-google-certificate-authority-service"
      org         = "GoogleCloudPlatform"
      description = "Create and manage CAS"
      maintainers = setunion(["viojha96","vandnagarggoogle"], local.adc_common_admins)
      topics      = local.common_topics.security
      lint_env = {
        ENABLE_BPMETADATA = "1"
      }
    },
References
  1. When combining lists where uniqueness is desired, use setunion() instead of concat() to automatically handle and prevent duplicate entries, as demonstrated for maintainers.

]
}
Loading