fix: replace Math.random() with crypto.randomUUID() in generateUUID()#691
Open
derek-codebridge wants to merge 1 commit into
Open
fix: replace Math.random() with crypto.randomUUID() in generateUUID()#691derek-codebridge wants to merge 1 commit into
derek-codebridge wants to merge 1 commit into
Conversation
crypto.randomUUID() is available in all environments where comlink runs: browsers (Chrome 92+, Firefox 95+, Safari 15.4+), Web Workers, Service Workers, and Node.js 19+. The previous implementation used Math.random() which is not cryptographically random and also produced non-RFC-4122 identifiers despite the function being named generateUUID.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
Done. CLA Completed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
generateUUID()usesMath.random()to produce message correlation IDs:Two issues:
Math.random()is a PRNG, not a CSPRNG. While these IDs never leave the browser, usingMath.random()for ID generation is a code quality issue that static analysis tools flag.generateUUID()but produceshex-hex-hex-hexstrings that don't conform to RFC 4122.Fix
crypto.randomUUID()is available in all environments where comlink runs:crypto.randomUUID()available since Node.js 19Testing
No test changes needed — this is a drop-in replacement with identical semantics for the callers. The ID is only used as a
pendingListenersmap key within the same process.