Repository navigation
Add an httpSMS Android release APK workflow - #1
Merged
Merged
Conversation
Add a GitHub Actions workflow that injects google-services.json and an optional release keystore from secrets, falling back to a debug signature. Stop tracking google-services.json, trust user-installed CAs, and keep the Server URL editable at runtime. Co-authored-by: Admin <GoDeskio@users.noreply.github.com>
2 of 12 tasks
Login and settings live in subpackages, so the Server URL validator did not resolve and the debug unit tests failed to compile. Co-authored-by: Admin <GoDeskio@users.noreply.github.com>
setup-android v3 asks sdkmanager for the legacy tools package, which cmdline-tools 16 no longer publishes. Pin v4 and install platform-tools only, and upload the APK with the Node 24 artifact action. Co-authored-by: Admin <GoDeskio@users.noreply.github.com>
GoDeskio
marked this pull request as ready for review
September 26, 2026 01:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Builds the current httpSMS-style Android app (
com.httpsms) in GitHub Actions and keeps the Server URL as a runtime setting..github/workflows/android.ymldecodesgoogle-services.jsonfromGOOGLE_SERVICES_JSON_BASE64, signs withANDROID_KEYSTORE_BASE64,ANDROID_KEYSTORE_PASSWORD,ANDROID_KEY_ALIAS, andANDROID_KEY_PASSWORDwhen all four are set, and otherwise signs the release APK with the debug key. The APK is uploaded ashttpsms-release-apk.android-actions/setup-android@v4withpackages: platform-tools. The v3 action installs the removedtoolspackage and fails on current runners.actions/upload-artifact@v7(Node 24).google-services.jsonis no longer tracked. A placeholder example remains, and ignore rules cover Firebase files, keystores, and private CA material.ANDROID_PRIVATE_CA_BASE64orANDROID_PRIVATE_CA_FILEis bundled only for that build and is not committed.docs/android-build.md.Manual steps
Add the Actions secrets listed in
docs/android-build.mdbefore the workflow can produce an APK. Pull requests from forks cannot read those secrets.GOOGLE_SERVICES_JSON_BASE64is set. The keystore secrets are optional; without them the APK is debug-signed.The previous
google-services.jsonis removed from the tree. It remains in git history from the upstream fork, so rotate that Firebase Android key if it should no longer be treated as public.Test plan
./gradlew :app:generateNetworkSecurityConfigwrites a config that trustssystemandusercertificatesANDROID_PRIVATE_CA_FILEset to a throwaway PEM, the same task also emitsres/raw/private_ca.crtand references@raw/private_ca./gradlew :app:testDebugUnitTest—ServerUrlsTest(3) andExampleUnitTest(1) passedhttpsms-release-apk(debug-signed; keystore secrets are unset)