Repository navigation
Add a branded Cache Me Outside site and a drop-in integration - #94
Merged
Merged
Conversation
The console key browser returned method not allowed, and the page depended on inline scripts. The site now creates, limits, browses, and deletes databases, and the agent can do those actions without a model. Co-authored-by: Admin <GoDeskio@users.noreply.github.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The management console could create a database, then failed the moment you tried to use it. This replaces that page with a site you can run on its own, and a small package other GoDesk apps can adopt.
What was broken
Clicked through the old console and the flow page in Chrome:
405 method not allowed.GET /v1/databases/{name}/keyswas tested and drawn in the page, and the handler never routed it.patternis invalid in current Chrome (vflag), so the field loggedInvalid character classand did not validate.unsafe-inlinescripts.401instead of404.What this changes
python3 site/server.py --demoserves the site on127.0.0.1only. Create, browse, limits, rotate, and delete run against an in-memory database, including a labeled sample key. The same pages are whatcmo_mgmt.pyserves when it is pointed at a real server.prefers-reduced-motionturns that off and stops the flow animation.OLLAMA_BASE_URLand drops any action outside that list.unsafe-inline.integration/is version1.0.0: a Python client, a browser/Node client, a loopback sidecar, and an updater.INTEGRATION.mdis the adoption note. The updater checksSHA256SUMSand will not write a symlink or a path that leaves the directory. No token is stored in the repo.Tests
Unit tests: management API, key browser, flow feed,
site/test_site.py,integration/test_integration.py.Browser:
site/e2e(Playwright). CI jobSite, integration, and browserruns those and uploads the screenshots. The Valkey build jobs are unchanged.