Repository navigation
Add main-thread incremental snapshots (snapshot-mode forkless) - #62
Merged
Merged
Conversation
Rebased onto unstable; kept CRDT hooks from #61 alongside forkless snapshot.
GoDeskio
force-pushed
the
cursor/forkless-snapshot-afeb
branch
from
November 5, 2026 10:49
a7c3309 to
085445f
Compare
GoDeskio
added a commit
that referenced
this pull request
Nov 5, 2026
Rebased onto unstable after forkless snapshot (#62); kept CRDT, hybrid flash, and forkless hooks.
GoDeskio
added a commit
that referenced
this pull request
Nov 5, 2026
Rebased onto unstable after forkless snapshot (#62); kept CRDT, hybrid flash, and forkless hooks. Co-authored-by: GoDesk <GoDeskio@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
snapshot-mode forkless, a main-thread RDB writer that saves a slice of keys per event-loop tick.fork().fsync. A crash mid-snapshot leaves the previous dump in place.cur_bgsave_typeto the existing background-thread forkless saver, so the two implementations do not claim the same save.Tests
./runtest --single unit/forkless-snapshot: consistency againstDEBUG DIGEST, memory under 1.2x the dataset, latency while a snapshot is open, crash mid-snapshot, and a cluster primary.make test— 5879 passed, 0 failed.Default remains
snapshot-mode fork.