Conversation
…measures (#1701) Closes #1696. Threshold 72 to 76, the integer under the 76.44% the Coverage job read on develop at a57e846 (run 33916825387, 2026-09-04). The comment beside it carries the measurement, the run, the date and the reason the local number (86.99% with Podman reachable) is not the one that gates. Signed-off-by: Jaro-c <75870284+Jaro-c@users.noreply.github.com> Signed-off-by: Jaro-c <75870284+Jaro-c@users.noreply.github.com>
…ery network name, and CREATED reads as a moment (#1702) Closes #1697, #1698 and #1699. Measured on the branch binary: ``` $ podup port talker 80 podup: error: talker publishes no host port for 80/tcp (exit 1) $ podup config | tail -3 networks: default: name: tpol_default $ podup ps NAME IMAGE CREATED STATUS PORTS tpol-talker-1 localhost/ux-talker:1 3 seconds ago Up 3s $ podup images SERVICE REPOSITORY TAG IMAGE ID SIZE CREATED talker localhost/ux-talker 1 51a0cce630f3 8.10MB 10 hours ago ``` - `port`: a new `ComposeError::PortNotPublished` variant (the enum is `non_exhaustive`) carries the sentence; `Unsupported` stays for what podup does not implement. Unit test asserts the text and the variant. - `config`: `resolve_network_name`, the function `up` calls, is now reachable from the binary crate and `config` stamps `name:` on every declared network without one; four unit tests plus `tests/config_contract.rs` (three cases against Podman, including `--hash`/`--quiet` unaffected). - CREATED: one `humanize_age` helper for both tables, boundaries pinned at 0 s, 1 s, 59 s, 60 s, 59 min, 60 min, 23 h, 24 h and singular versus plural; the JSON rows keep their raw instants (existing contract test). Suite, clippy and fmt clean locally. Signed-off-by: Jaro-c <75870284+Jaro-c@users.noreply.github.com> --------- Signed-off-by: Jaro-c <75870284+Jaro-c@users.noreply.github.com>
… at the top (#1703) Closes #1700. Measured under a pseudo-terminal with the branch binary, frames deduplicated: ``` $ podup up -d --build [+] Running 0/3 ✔ Image localhost/ux-talker:1 Built 0.3s [+] Running 1/3 ✔ Network tup_default Created 0.0s [+] Running 2/3 ✔ Container tup-talker-1 Started 0.1s ``` One board. The image rows sit at the top and are built one after another, in `build`'s order, before the network and container stages start; `dispatch.rs` no longer calls `build_all` for `--build`. `build` alone still draws its own board (`[+] Running 0/1`), and `up` with a missing image and no `--build` keeps the image row above the container row on the up board. Two things found on the way: - `build/mod.rs` went past the line limit, so `build_service` lives in `build/service.rs` now (private module of `build`); `build/mod.rs` is 167 code lines. - The image row `up` inserts for a missing image rendered as `localhost/u…` while the seeded rows fit: the name column was sized at `begin` from the seeded names only. A row added after `begin` now widens it (same 12 to 40 clamp), with a unit test. Tests: `up_build_draws_a_single_board_with_the_image_row_first` (one board, image row first, `Built` before any container event, against the fake Podman), `a_row_added_after_begin_widens_the_name_column`; the existing missing-image and build board tests stay green. Suite, contract tests, clippy and fmt clean locally. Signed-off-by: Jaro-c <75870284+Jaro-c@users.noreply.github.com> Signed-off-by: Jaro-c <75870284+Jaro-c@users.noreply.github.com>
Patch release for the CLI polish that landed after 5.9.0: one board for up --build, the widened name column, port's plain message, config's resolved network names and CREATED as a moment. No engine change. ## Verified The three version comparisons of release.yml run locally: crate=5.9.1 lock=5.9.1 deb=5.9.1, GATE OK; cargo metadata --locked accepts the lockfile. Signed-off-by: Jaro-c <75870284+Jaro-c@users.noreply.github.com> Signed-off-by: Jaro-c <75870284+Jaro-c@users.noreply.github.com> Signed-off-by: Jaro-c <75870284+Jaro-c@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release
develop→mainfor 5.9.1. Merge commit, not squash:mainis the released state.What ships
A patch release for the CLI polish that landed after 5.9.0. No engine change.
up --builddraws one board (#1700, PR #1703). The image rows sit at the top and are built one after another, inbuild's order, before the network and container stages; one[+] Runningcount covers everything. A row added to a board after it opened now widens the name column, so the image rowupinserts for a missing image is no longer cut tolocalhost/u….Three small things read right (#1697, #1698, #1699, PR #1702).
porton a port the service does not publish saystalker publishes no host port for 80/tcpunder its own error variant instead ofunsupported feature;configprints the resolvedname:of every network, the default one included, through the functionupuses; CREATED inpsandimagesreads3 seconds ago, not3s.CI. The coverage threshold is 76, the floor under the 76.44% the job measured on develop (#1696, PR #1701).
Verified before opening this
release.ymllocally:crate=5.9.1 lock=5.9.1 deb=5.9.1, GATE OK;cargo metadata --lockedaccepts the lockfile.Signed-off-by: Jaro-c 75870284+Jaro-c@users.noreply.github.com