Conversation
…ws leg signs with an x64 Python (#1694) Closes #1692. Replaces #1693, which targeted main; the main guard requires develop, and a dispatched release checks out the tag, so the script fix must reach the tag through main anyway. - `check-hardening-macos.sh` reads the flags off `otool -h`'s value line (the one starting with the magic), not the column-name line. - `lint-shell.yml` gains a `macos-latest` job: the fixture with its clang-built controls, then a release-profile build and the gate on the real binary. On #1693 that job ran the fixture on a Mac for the first time and found a second gap: the unstripped control had no local symbol to strip, so it passed; the control now has a static helper. - The windows-arm64 leg sets up an x64 Python 3.12 before signing; the sign step uses `python` when a setup step provided it. The `windows-11-arm` pull-request job installs the signing dependencies under `--require-hashes` the same way; #1693 was closed before that job finished, so this pull request is where it runs. - The matrix comment that said the wheels were x64-only, which #1683 moved past, now says what the leg does about it. Threat-model row updated. Signed-off-by: Jaro-c <75870284+Jaro-c@users.noreply.github.com> --------- Signed-off-by: Jaro-c <75870284+Jaro-c@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release
develop→mainfor 5.9.0, second pass. Merge commit, not squash.The first run on
v5.9.0(33911807587) stopped both darwin legs at the new macOS gate and the windows-arm64 leg at signing; nothing was signed or published. #1694 fixes both and adds the jobs that would have caught them before a tag: the macOS fixture ran on a Mac for the first time and corrected three of its own controls, and thewindows-11-armjob installs the signing wheels the release installs. Both green on #1694.The tag
v5.9.0is recreated on this merge commit, since the release checks out the tag and the script fix has to be in it; the previous tag never became a release.What ships is unchanged from #1691.
Signed-off-by: Jaro-c 75870284+Jaro-c@users.noreply.github.com