Conversation
…#1652) Fixes #1651. `cargo build` with default features, and with the Debian feature set, now prints no warnings; `--all-features` clippy unchanged. This pull request is also the probe for CodeQL on `develop`: the classic branch protection rule for `develop` was created tonight, and default setup scans "main and protected branches". If a CodeQL check appears here, `develop` counts. Signed-off-by: Jaro-c <75870284+Jaro-c@users.noreply.github.com> Signed-off-by: Jaro-c <75870284+Jaro-c@users.noreply.github.com>
## What `docs/benchmarks.md`, the README summary and `docs/assets/bench.svg` regenerated from a full run on 5.7.1: 1044 timed runs in ten minutes, none failed, `bench/aggregate.py` and `bench/chart.py` untouched. ## What the numbers say - Same Podman, podman-compose and docker-compose as the 3.4.1 run, so the tables read against each other for the first time. The unchanged reference (`docker-compose`) moved -6.5%, podup -5.7%: flat across nine releases. - Peak memory per command: median 8.0 MiB to **5.6 MiB**, worst case 8.6 to 6.5. The memory budget gate (9.0) passes. - `logs` rows -66% and -55%, `ps` rows -28% and -22%. - `config-heavy config` prints +38% against the old table and a head-to-head on this machine, alternating binaries, reads 11.7 ms (3.4.1) against 11.6 ms (5.7.1). Published as measured, with that reading beside it. - Three teardown wins are ties (gap inside podup's own sd), five more are within two sd; all named. ## Two things that moved the numbers before the real run 1. A first run used `target/release/podup` from `cargo build --release` on this glibc host: dynamically linked, 6.4 MB RSS on `--version` where every published asset reads 3.3-3.7 MB. Discarded; the run above measures the published `podup-linux-x86_64` asset. `bench/README.md` now says to build the musl target. 2. Podman's storage held 248 networks, 316 dangling images and 115 volumes, almost all leftovers of integration tests; `podman ps` took 56 ms and 28 ms after removing them. podman-compose, which shells out per call, moved +33% in that first run with no change of its own. The counts at the start of the real run are in the methodology paragraph. Signed-off-by: Jaro-c <75870284+Jaro-c@users.noreply.github.com> Signed-off-by: Jaro-c <75870284+Jaro-c@users.noreply.github.com>
Jaro-c
added
type:docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promote
develop→mainso the README anddocs/benchmarks.mdon the default branch carry the 5.7.1 measurements (#1653). Merge commit, not squash.No version change and no tag: the only code change is #1652, an
allow(dead_code)scoped to builds withouttest-helpers, which alters no behaviour. Same shape as #1650.Signed-off-by: Jaro-c 75870284+Jaro-c@users.noreply.github.com