Conversation
MINOR. No pull request in this release carries the breaking label, which standards/releases makes the marker, and no command's flags or output changed. The one arguable case is podup update now refusing on Homebrew and Scoop where it previously overwrote -- but what it did before corrupted the manager's record of the file, so it is a fix rather than a withdrawal of function. Three manifests, not two. Cargo.lock stamps the version as well and --locked refuses to update it during a build, so a bump touching only Cargo.toml and debian/changelog leaves the lock claiming 5.4.0 and the release build fails at the gate rather than at review -- which is where it cannot be fixed, because releases are immutable. cargo build --locked succeeding is what proves the lock was updated rather than assumed. dpkg-parsechangelog reads the new entry: Source podup, Version 5.5.0. That file is where dpkg-buildpackage takes the .deb version from, and a .deb labelled with the version the user already has means apt reports nothing to upgrade. Signed-off-by: Jaro-c <75870284+Jaro-c@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The release pull request for 5.5.0. Everything else in it was already promoted; this carries the version stamp so
v5.5.0can be tagged onmain.What 5.5.0 changes for a user
podup updateno longer overwrites a Homebrew or Scoop install (fix(update): detect Homebrew and Scoop, not only apt #1609). It refused only for dpkg, and off Linux did not look at all, so on those two it rewrote the binary underneath a manifest that still claimed to know the contents. It now names each manager's own upgrade command.glyndor-archive-keyring(fix(packaging): require glyndor-archive-keyring #1607), which ships that rule.No command's flags or output changed.
MINOR
No pull request in this release carries the
breakinglabel, whichstandards/releasesmakes the marker. The one arguable case ispodup updaterefusing where it previously overwrote — and what it did before corrupted the manager's record of the file, so it is a fix rather than a withdrawal.Test plan
Cargo.toml,Cargo.lock,debian/changelog. The lock is the one a two-file bump misses, and--lockedrefuses to fix it during a build, so it would have failed at tag time rather than at reviewdpkg-parsechangelogreads the entry: Source podup, Version 5.5.0develop: 27 checks, 0 failuresrust/cleartext-loggingalerts areclosed as fixedonmain, and code scanning reports 0 openAfter this
Tag
v5.5.0onmain, which is whatrelease.ymlfires on. Releases are immutable org-wide, so that is the step with no undo.Signed-off-by: Jaro-c 75870284+Jaro-c@users.noreply.github.com