Repository navigation
ci(mobile): novedades de las tiendas desde mobile/whatsnew, no desde la PR - #263
Merged
Merged
Conversation
…la PR Las notas de Play y App Store salian del titulo y cuerpo de la PR fusionada, asi que la 1.0.12 publico texto interno de CI. Ahora salen solo de mobile/whatsnew/whatsnew-<locale>, cada idioma con su texto, y el CI comprueba el limite de 500 caracteres de Play y ejecuta el mock del envio a App Store.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problema
La 1.0.12 salió a Play (producción) y a revisión de App Store con «Novedades» copiadas del título y el cuerpo de la PR #262, que eran texto interno de CI.
generate-whatsnew.shtomaba las notas de la PR fusionada o del cuerpo del GitHub Release, y en iOS además ponía el mismo texto en todos los idiomas.Ya corregido en las tiendas, fuera de esta PR, el 3-nov:
WAITING_FOR_REVIEWconAFTER_APPROVAL.Cambios
generate-whatsnew.shy sus tres pasos. Las notas salen solo demobile/whatsnew/whatsnew-es-ESywhatsnew-en-US, que se versionan junto con el cambio de versión.app-store-submit.mjs: conRELEASE_NOTES_DIRcada localización recibe su propiowhatsnew-<locale>. Una localización sin fichero propio recibe el dees-ES.ci.yml(Quality Checks):whatsnew-*pasa de 500 caracteres. Antes el error salía al subir a Play, tras el build.AGENTS.md: añade al flujo de release el paso de escribir las novedades.Pruebas
stale,other-409ynewer-editableOK. Con el fallo anterior reintroducido (mismo texto en todos los idiomas),staleyother-409fallan.prettier --checkynode --checken verde.